From a4bbf98dbf6c8d754c2a85b18ff91f5e5b196236 Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date: Thu, 2 Apr 2026 10:32:06 +0000
Subject: [PATCH] Bug 41849: Add tests

Test plan:
1) Enable DisplayAddHoldGroups sys prefs
2) Go to 'Henry' and click 'Search to hold':
<staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19
3) Search for 'test' and click the top 'Select all' link
4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry'
5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox
6) Click 'Place holds'.
7) Check-in any eligible barcode e.g.: 39999000005578
8) Click 'Confirm hold'.
9) Check-in that same barcode.
10) Notice the modal now shows 'Part of a hold group' with a link to the patron's holds table
11) Notice the modal now shows a 'Cancel all holds in hold group' button. Click the button. Confirm all holds are cancelled.

prove t/db_dependent/api/v1/patrons_hold_groups.t

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 t/db_dependent/api/v1/patrons_hold_groups.t | 79 ++++++++++++++++++++-
 1 file changed, 78 insertions(+), 1 deletion(-)

diff --git a/t/db_dependent/api/v1/patrons_hold_groups.t b/t/db_dependent/api/v1/patrons_hold_groups.t
index 37ee9016bd..df68be5738 100755
--- a/t/db_dependent/api/v1/patrons_hold_groups.t
+++ b/t/db_dependent/api/v1/patrons_hold_groups.t
@@ -18,7 +18,7 @@
 use Modern::Perl;
 
 use Test::NoWarnings;
-use Test::More tests => 4;
+use Test::More tests => 5;
 use Test::MockModule;
 use Test::Mojo;
 
@@ -254,3 +254,80 @@ subtest 'delete() tests' => sub {
 
     $schema->storage->txn_rollback;
 };
+
+subtest 'cancel() tests' => sub {
+    plan tests => 10;
+
+    $schema->storage->txn_begin;
+
+    my $patron = $builder->build_object(
+        {
+            class => 'Koha::Patrons',
+            value => { flags => 2**6 }    # reserveforothers
+        }
+    );
+    my $password = 'thePassword123';
+    $patron->set_password( { password => $password, skip_validation => 1 } );
+    my $userid = $patron->userid;
+
+    my $hold1 = $builder->build_object(
+        {
+            class => 'Koha::Holds',
+            value => {
+                borrowernumber => $patron->id,
+                found          => undef,
+                hold_group_id  => undef,
+            }
+        }
+    );
+    my $hold2 = $builder->build_object(
+        {
+            class => 'Koha::Holds',
+            value => {
+                borrowernumber => $patron->id,
+                found          => undef,
+                hold_group_id  => undef,
+            }
+        }
+    );
+
+    my $hold_group = $patron->create_hold_group( [ $hold1->id, $hold2->id ] );
+    my $hg_id      = $hold_group->id;
+
+    # 2. Test Cancellation via API
+    my $reason = "Customer changed their mind";
+
+    {
+        # Mocking letters locally to prevent "No HOLD_CANCELLATION letter" exceptions
+        my $mock_letters = Test::MockModule->new('C4::Letters');
+        $mock_letters->mock( 'GetPreparedLetter', sub { return } );
+        $mock_letters->mock( 'EnqueueLetter',     sub { return } );
+
+        $t->post_ok( "//$userid:$password@/api/v1/patrons/"
+                . $patron->id
+                . "/hold_groups/$hg_id/cancel" => json => { cancellation_reason => $reason } )
+            ->status_is( 204, 'REST API returns 204 No Content on success' );
+    }
+
+    # 3. Verify Holds were moved to old_reserves
+    my $old_hold1 = Koha::Old::Holds->find( $hold1->id );
+    my $old_hold2 = Koha::Old::Holds->find( $hold2->id );
+
+    ok( $old_hold1 && $old_hold2, 'Both holds moved to old_reserves' );
+    is( $old_hold1->cancellation_reason, $reason, 'Correct cancellation reason stored for hold 1' );
+    is( $old_hold2->cancellation_reason, $reason, 'Correct cancellation reason stored for hold 2' );
+
+    # 4. Verify the group was cleaned up
+    my $deleted_group = Koha::HoldGroups->find($hg_id);
+    is( $deleted_group, undef, 'The hold group was automatically deleted after bulk cancellation' );
+
+    # 5. Verify they are no longer in the active reserves table
+    is( Koha::Holds->find( $hold1->id ), undef, 'Hold 1 removed from active holds' );
+    is( Koha::Holds->find( $hold2->id ), undef, 'Hold 2 removed from active holds' );
+
+    # 6. Test 404 for non-existent group
+    $t->post_ok( "//$userid:$password@/api/v1/patrons/" . $patron->id . "/hold_groups/99999/cancel" )
+        ->status_is( 404, 'Returns 404 for non-existent hold group' );
+
+    $schema->storage->txn_rollback;
+};