Bug 36915: (QA follow-up) Passing less to encourage traversal

I generally push for contextual use of accessors in TT notices and try
to reduce extra lookups.

In this case we can access the pickup library branchname directly using
the pickup_library relation available to us in the booking object we
pass.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Koha/Booking.pm

@@ -262,7 +262,7 @@ sub delete {
         message_transport_type => 'email',
         branchcode             => $pickup_library->branchcode,
         lang                   => $patron->lang,
-        objects                => { booking => $self, branch => $pickup_library }
+        objects                => { booking => $self }
     );
 
     if ($letter) {

installer/data/mysql/en/mandatory/sample_notices.yml

@@ -64,7 +64,7 @@ tables:
             - "<br>"
             - "Kind regards<br>"
             - "<br>"
-            - "[% branch.branchname %]"
+            - "[% booking.pickup_library.branchname %]"
 
         - module: catalogue
           code: TICKET_ACKNOWLEDGE