gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24081: Add DISCOUNT to the allowed 'reduce' types 

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Martin Renvoize 2020-01-09 14:14:34 +00:00
parent 12381ead91
commit a2fa0acb7d
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Koha/Account/Line.pm
View File

@ -291,6 +291,7 @@ debts.
Reduction type may be one of:
* REFUND
* DISCOUNT
Returns the reduction accountline (which will be a credit)
@ -339,14 +340,14 @@ sub reduce {
"Amount to reduce ($params->{amount}) is higher than original amount ($original)"
) unless ( $original >= $params->{amount} );
my $reduced =
$self->credits( { credit_type_code => [ 'REFUND' ] } )->total;
$self->credits( { credit_type_code => [ 'DISCOUNT', 'REFUND' ] } )->total;
Koha::Exceptions::ParameterTooHigh->throw( error =>
"Combined reduction ($params->{amount} + $reduced) is higher than original amount ("
. abs($original)
. ")" )
unless ( $original >= ( $params->{amount} + abs($reduced) ) );
my $status = { 'REFUND' => 'REFUNDED' };
my $status = { 'REFUND' => 'REFUNDED', 'DISCOUNT' => 'DISCOUNTED' };
my $reduction;
$self->_result->result_source->schema->txn_do(