gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40966: Regression tests 

Tests verify that whole_record and weighted_fields parameters are
correctly included in the query_cgi string returned by build_query_compat(),
ensuring these parameters are preserved in facet links and pagination.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> FAIL: The values are not being passed around

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Tomás Cohen Arazi 2025-10-07 11:45:02 -03:00 committed by Lucas Gass
parent 3dd5eda7d5
commit a1fa2dc71e
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
View File

@ -252,7 +252,7 @@ subtest 'build_authorities_query_compat() tests' => sub {
};
subtest 'build_query tests' => sub {
plan tests => 69;
plan tests => 72;
my $qb;
@ -342,6 +342,31 @@ subtest 'build_query tests' => sub {
is( $query_cgi, 'idx=ti&q=%22donald%20duck%22&idx=au&q=walt%20disney', 'query cgi ok for multiterm query' );
is( $query_desc, '(title:("donald duck")) (author:(walt disney))', 'query desc ok for multiterm query' );
# Test whole_record and weighted_fields parameters in query_cgi
( undef, $query, $simple_query, $query_cgi, $query_desc ) = $qb->build_query_compat(
undef, ['test'], ['kw'], undef, undef, undef, undef,
{ whole_record => 1, weighted_fields => 1, weight_search_submitted => 1 }
);
is(
$query_cgi, 'idx=kw&q=test&weight_search=1&weight_search_submitted=1&whole_record=1',
'query_cgi includes whole_record, weight_search and weight_search_submitted parameters'
);
( undef, $query, $simple_query, $query_cgi, $query_desc ) = $qb->build_query_compat(
undef, ['test'], ['kw'], undef, undef, undef, undef,
{ whole_record => 1 }
);
is( $query_cgi, 'idx=kw&q=test&whole_record=1', 'query_cgi includes whole_record parameter only' );
( undef, $query, $simple_query, $query_cgi, $query_desc ) = $qb->build_query_compat(
undef, ['test'], ['kw'], undef, undef, undef, undef,
{ weighted_fields => 1, weight_search_submitted => 1 }
);
is(
$query_cgi, 'idx=kw&q=test&weight_search=1&weight_search_submitted=1',
'query_cgi includes weight_search and weight_search_submitted parameters only'
);
( undef, $query ) = $qb->build_query_compat( undef, ['2019'], ['yr,st-year'] );
is(
$query->{query}{bool}{must}[0]{query_string}{query},