Bug 41521: Silent perlcritic warnings
Stricture disabled at line 67, column 5. See page 429 of PBP. (Severity: 5) We should deal with that later instead of ignoring the warnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
This commit is contained in:
parent
d0ee8f5a6e
commit
a12aac8957
|
|
@ -104,7 +104,7 @@ sub with_json_request {
|
||||||
my $method = shift || 'post';
|
my $method = shift || 'post';
|
||||||
|
|
||||||
my $req_builder = "HTTP::Request::Common::".uc( $method );
|
my $req_builder = "HTTP::Request::Common::".uc( $method );
|
||||||
no strict 'refs';
|
no strict 'refs'; ## no critic (ProhibitNoStrict)
|
||||||
my $request = $req_builder->( $url );
|
my $request = $req_builder->( $url );
|
||||||
$self->_json_request_content($request, $post_params);
|
$self->_json_request_content($request, $post_params);
|
||||||
my $response = $self->_request_with_auth($request);
|
my $response = $self->_request_with_auth($request);
|
||||||
|
|
|
||||||
|
|
@ -273,7 +273,7 @@ sub native_search {
|
||||||
}
|
}
|
||||||
|
|
||||||
foreach my $f (qw(next prev first last)) {
|
foreach my $f (qw(next prev first last)) {
|
||||||
no strict 'refs';
|
no strict 'refs'; ## no critic (ProhibitNoStrict)
|
||||||
my $method = "native_search_$f";
|
my $method = "native_search_$f";
|
||||||
*$method = sub {
|
*$method = sub {
|
||||||
my $self = shift;
|
my $self = shift;
|
||||||
|
|
|
||||||
|
|
@ -63,7 +63,7 @@ Differences to general L<WebService::ILS> interface
|
||||||
=cut
|
=cut
|
||||||
|
|
||||||
foreach my $sub (qw(place_hold remove_hold renew return)) {
|
foreach my $sub (qw(place_hold remove_hold renew return)) {
|
||||||
no strict "refs";
|
no strict "refs"; ## no critic (ProhibitNoStrict)
|
||||||
*$sub = sub {
|
*$sub = sub {
|
||||||
my $self = shift;
|
my $self = shift;
|
||||||
my $patron_id = shift or croak "No patron id";
|
my $patron_id = shift or croak "No patron id";
|
||||||
|
|
|
||||||
|
|
@ -73,7 +73,7 @@ sub with_xml_request {
|
||||||
my $method = shift || 'post';
|
my $method = shift || 'post';
|
||||||
|
|
||||||
my $req_builder = "HTTP::Request::Common::".uc( $method );
|
my $req_builder = "HTTP::Request::Common::".uc( $method );
|
||||||
no strict 'refs';
|
no strict 'refs'; ## no critic (ProhibitNoStrict)
|
||||||
my $request = $req_builder->( $url );
|
my $request = $req_builder->( $url );
|
||||||
$request->header( 'Content-Type' => 'application/xml; charset=utf-8' );
|
$request->header( 'Content-Type' => 'application/xml; charset=utf-8' );
|
||||||
$request->content( $dom->toeString );
|
$request->content( $dom->toeString );
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue