gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 29987: (follow-up) Fix missing payment type 

The payment type include has changed since the patch was first written,
we now require a 'type' is passed to properly set the field name.

This should fix the 'bankable' issue raised.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2022-08-24 11:23:25 +01:00 committed by Tomas Cohen Arazi
parent 529341c78b
commit a059392490
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
View File

@ -76,7 +76,7 @@
<li><label for="desc">Description: </label><input type="text" name="desc" size="50" id="desc" /></li>
<li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
<li><label for="amount">Amount: </label><input type="text" inputmode="decimal" pattern="^\d+(\.\d{2})?$" name="amount" id="amount" required="required" min="0" value=""/> Example: 5.00</li>
[% INCLUDE 'transaction_types.inc' %]
[% INCLUDE 'transaction_types.inc' type="credit" %]
[% IF Koha.Preference('UseCashRegisters') %]
<li>
[% IF Koha.Preference('RequireCashRegister') %]

12
members/mancredit.pl
View File

@ -86,11 +86,11 @@ if ($add) {
my $item = Koha::Items->find( { barcode => $barcode } );
$item_id = $item->itemnumber if $item;
}
my $description = $input->param('desc');
my $note = $input->param('note');
my $amount = $input->param('amount') || 0;
my $type = $input->param('type');
my $payment_type = $input->param('payment_type');
my $description = $input->param('desc');
my $note = $input->param('note');
my $amount = $input->param('amount') || 0;
my $type = $input->param('type');
my $credit_type = $input->param('credit_type');
my $cash_register_id = $input->param('cash_register');
my $line = $patron->account->add_credit(
@ -103,7 +103,7 @@ if ($add) {
type => $type,
user_id => $logged_in_user->id,
interface => C4::Context->interface,
payment_type => $payment_type,
payment_type => $credit_type,
cash_register => $cash_register_id
}
);