gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23695: (QA follow-up) Revert 'Orginating library' option 

At my request, we added an 'Originating library' option to the manual
transfers form.

However, we did not properly pass this through in the controller and I
have since discovered that my request was ill conceived/a
misunderstanding of requirements.

This patch removes the option from the template and drops the references
to it in the controller.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2020-10-09 11:28:12 +01:00 committed by Jonathan Druart
parent a9f2fc1eb9
commit 9ddb312749
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
circ/branchtransfers.pl
View File

@ -79,7 +79,6 @@ my $setwaiting;
my $request = $query->param('request') || '';
my $borrowernumber = $query->param('borrowernumber') || 0;
my $frombranchcd = $query->param('frombranchcd') || C4::Context->userenv->{'branch'};
my $tobranchcd = $query->param('tobranchcd') || '';
my $ignoreRs = 0;
@ -223,7 +222,6 @@ $template->param(
itemnumber => $itemnumber,
barcode => $barcode,
biblionumber => $biblionumber,
frombranchcd => $frombranchcd,
tobranchcd => $tobranchcd,
reqmessage => $reqmessage,
cancelled => $cancelled,

8
koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
View File

@ -72,7 +72,6 @@
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
<input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" />
<input type="hidden" name="tobranchcd" value="[% tobranchcd | html %]" />
<input type="hidden" name="frombranchcd" value="[% frombranchcd | html %]" />
<input type="hidden" name="barcode" value="[% barcode | html %]" />
<input type="hidden" name="request" value="KillReserved" />
<input type="submit" value="Cancel" />
@ -152,13 +151,6 @@
<fieldset class="brief">
<legend>Transfer</legend>
<ol>
<li>
<label for="frombranchcd">Originating library: </label>
<select name="frombranchcd" id="frombranchcd">
<option value="current_holding">Item's holding branch</option>
[% PROCESS options_for_libraries libraries => Branches.all( selected => '', unfiltered => 1) %]
</select>
</li>
<li>
<label for="tobranchcd">Destination library: </label>
<select name="tobranchcd" id="tobranchcd">