From 9b8132a0c81e010201b1edf06b618e76fcbc0181 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 20 Feb 2026 11:02:14 +0100 Subject: [PATCH] Bug 36752: Remove confusing TODOs As Jan Kissig correctly mentioned on the BZ report, the various summary info on charged items etc. are included. This is done via the summary_info sub. Note that the TODOs about BZ FID_HOLD_ITEMS_LMT CA FID_OVERDUE_ITEMS_LMT CB FID_CHARGED_ITEMS_LMT are still valid. This is not included yet. Test plan. Since we are just removing comments, read the code. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Laura Escamilla --- C4/SIP/Sip/MsgType.pm | 7 ------- 1 file changed, 7 deletions(-) diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm index 9f1cdd5460..576520d49c 100644 --- a/C4/SIP/Sip/MsgType.pm +++ b/C4/SIP/Sip/MsgType.pm @@ -1124,13 +1124,6 @@ sub handle_patron_info { $resp .= maybe_add( FID_FEE_AMT, $patron->fee_amount, $server ); $resp .= add_field( FID_FEE_LMT, $patron->fee_limit, $server ); - # TODO: zero or more item details for 2.0 can go here: - # hold_items - # overdue_items - # charged_items - # fine_items - # recall_items - $resp .= summary_info( $ils, $patron, $summary, $start, $end, $server ); $resp .= maybe_add( FID_HOME_ADDR, $patron->address, $server );