gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40529: (QA follow-up): Add skip logic to GetPendingHoldRequestsForBib 

This fixes the issue reported by Andrew on comment 23.
Following the scenario he describes, the hold should now still appear, but attached to the correct patron (Patron B).
This was an oversight as I wasn't aware of GetPendingHoldRequestsForBib and had only added the skip logic to GetBibsWithPendingHoldRequests.

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Pedro Amorim 2025-09-23 13:48:05 +00:00 committed by Lucas Gass
parent 8426becada
commit 9a03ec6a28
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
C4/HoldsQueue.pm
View File

@ -267,7 +267,6 @@ sub GetBibsWithPendingHoldRequests {
$sth->execute();
my $biblionumbers = $sth->fetchall_arrayref();
return [ map { $_->[0] } @$biblionumbers ];
}
@ -299,6 +298,9 @@ sub GetPendingHoldRequestsForBib {
my $dbh = C4::Context->dbh;
my $skip_non_target_holds_query = Koha::HoldGroup::skip_non_target_holds_query('sql');
my $skip_non_target_holds_query_sql = $skip_non_target_holds_query ? " $skip_non_target_holds_query" : '';
my $request_query = "SELECT biblionumber, borrowernumber, itemnumber, priority, reserve_id, reserves.branchcode,
reservedate, reservenotes, borrowers.branchcode AS borrowerbranch, itemtype, item_level_hold, item_group_id
FROM reserves
@ -309,6 +311,7 @@ sub GetPendingHoldRequestsForBib {
AND reservedate <= CURRENT_DATE()
AND suspend = 0 ";
$request_query .= "AND reserve_id NOT IN (SELECT reserve_id FROM hold_fill_targets) " if $unallocated;
$request_query .= $skip_non_target_holds_query_sql;
$request_query .= "ORDER BY priority";
my $sth = $dbh->prepare($request_query);
$sth->execute($biblionumber);