gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20000: Use Modern::Perl in installer scripts 

To test:

Check that we are using Modern::Perl when strict *and* warnings were used before,
and commented lines and FIXMEs have been removed from the rest, out of
files listed below.

data/mysql/backfill_statistics.pl
data/mysql/labels_upgrade.pl
data/mysql/patroncards_upgrade.pl
data/mysql/update22to30.pl
data/mysql/updatedatabase.pl
externalmodules.pl
html-template-to-template-toolkit.pl
install.pl

Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 20a38ee50e)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Aleisha Amohia 2018-12-19 20:32:32 +00:00 committed by Martin Renvoize
parent 9199083de8
commit 99cd91ad2d
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
8 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
installer/data/mysql/backfill_statistics.pl
View File

@ -3,8 +3,7 @@
# Part of the Koha Library Software www.koha-community.org
# Licensed under the GPL.
use strict;
use warnings;
use Modern::Perl;
# CPAN modules
use DBI;

3
installer/data/mysql/labels_upgrade.pl
View File

@ -17,9 +17,6 @@
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
#use strict;
#use warnings; FIXME - Bug 2505
use C4::Context;
my $sth = C4::Context->dbh;

3
installer/data/mysql/patroncards_upgrade.pl
View File

@ -17,9 +17,6 @@
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
#use strict;
#use warnings; FIXME - Bug 2505
use C4::Context;
my $sth = C4::Context->dbh;

1
installer/data/mysql/update22to30.pl
View File

@ -12,7 +12,6 @@
# NOTE: If you do something more than once in here, make it table driven.
use strict;
#use warnings; FIXME - Bug 2505
# CPAN modules
use DBI;

3
installer/data/mysql/updatedatabase.pl
View File

@ -27,8 +27,7 @@
# NOTE: Please keep the version in kohaversion.pl up-to-date!
use strict;
use warnings;
use Modern::Perl;
use feature 'say';

5
installer/externalmodules.pl
View File

@ -4,10 +4,9 @@
# It provides you not only the list of modules BUT ALSO the files that uses those modules.
# utf8 or warnings or other lib use are not taken into account at the moment.
use strict;
use warnings;
use Modern::Perl;
use C4::Context;
my $dir=C4::Context->config('intranetdir');
qx(grep -r "^ *use" $dir | grep -v "C4\|strict\|vars" >/tmp/modulesKoha.log);
$dir=C4::Context->config('opacdir');

3
installer/html-template-to-template-toolkit.pl
View File

@ -1,7 +1,6 @@
#!/usr/bin/perl
use strict;
use warnings;
use Modern::Perl;
use Carp;
use Data::Dumper;

3
installer/install.pl
View File

@ -17,8 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
use Modern::Perl;
use diagnostics;
use C4::InstallAuth;