Bug 13277: t/SuggestionEngine_AuthorityFile.t shouldn't depend on the DB

To reproduce:
- Stop your MySQL server:
  $ sudo service mysql stop
- Run
  $ prove t/SuggestionEngine_AuthorityFile.t
=> FAIL: some tests fail because of mysql stopped

To test (MySQL still stopped)
- Apply the patch
- Run
  $ prove t/SuggestionEngine_AuthorityFile.t
=> SUCCESS: tests pass because the ycan be loaded regardless of
            the absence of the DB server
- Sign off :-D

Regards

Signed-off-by: Magnus Enger <digitalutvikling@gmail.com>
Turned off MySQL and ran the tests before and after the patch.
Works as advertized.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Tomas Cohen Arazi 2014-11-17 22:59:49 -05:00
parent b8a0eefc23
commit 98fcda28ff
1 changed files with 29 additions and 5 deletions

View File

@ -1,20 +1,42 @@
#!/usr/bin/perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
# This Koha test module uses Test::MockModule to get around the need for known
# contents in the authority file by returning a single known authority record
# for every call to SearchAuthorities
use strict;
use warnings;
use Modern::Perl;
use File::Spec;
use MARC::Record;
use Test::More;
use Test::MockModule;
use DBD::Mock;
BEGIN {
use_ok('Koha::SuggestionEngine');
}
# Mock the DB connexion and C4::Context
my $context = new Test::MockModule('C4::Context');
$context->mock( '_new_dbh', sub {
my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
|| die "Cannot create handle: $DBI::errstr\n";
return $dbh;
});
use_ok('Koha::SuggestionEngine');
my $module = new Test::MockModule('C4::AuthoritiesMarc');
$module->mock('SearchAuthorities', sub {
@ -41,3 +63,5 @@ my $result = $suggestor->get_suggestions({search => 'Cookery'});
is_deeply($result, [ { 'search' => 'an=1234', 'relevance' => 1, 'label' => 'Cooking' } ], "Suggested correct alternative to 'Cookery'");
done_testing();
1;