gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40168: Restore afterEach in KohaTable Cypress tests 

We defined an anonymous function inside an arrow function, and Cypress does not call it.

Test plan:
Set AlwaysShowHoldingsTableFilters to "Do not"
Run t/cypress/integration/KohaTable/Holdings_spec.ts:
  yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts

When done, have a look at the value of AlwaysShowHoldingsTableFilters
=> without this patch it has been modified (not restored) and is set to
"Do"
=> With this patch applied the original value is restored at the end of
the tests (actually the end of each test)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit b83df697de)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-06-16 16:06:57 +02:00 committed by Paul Derscheid
parent c336f23cd0
commit 98ca5b0800
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
2 changed files with 21 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
t/cypress/integration/KohaTable/Holdings_spec.ts
View File

@ -109,16 +109,13 @@ describe("catalogue/detail/holdings_table with items", () => {
});
});
afterEach(
() =>
function () {
cleanup();
cy.set_syspref(
"AlwaysShowHoldingsTableFilters",
this.syspref_AlwaysShowHoldingsTableFilters
);
}
);
afterEach(function () {
cleanup();
cy.set_syspref(
"AlwaysShowHoldingsTableFilters",
this.syspref_AlwaysShowHoldingsTableFilters
);
});
it("Correctly init the table", function () {
// Do not use `() => {` or this.biblio_id won't be retrieved
@ -502,16 +499,13 @@ describe("catalogue/detail/holdings_table without items", () => {
});
});
afterEach(
() =>
function () {
cleanup();
cy.set_syspref(
"AlwaysShowHoldingsTableFilters",
this.syspref_AlwaysShowHoldingsTableFilters
);
}
);
afterEach(function () {
cleanup();
cy.set_syspref(
"AlwaysShowHoldingsTableFilters",
this.syspref_AlwaysShowHoldingsTableFilters
);
});
it("Do not display the table", function () {
// Do not use `() => {` or this.biblio_id won't be retrieved

17
t/cypress/integration/KohaTable/PatronSearch_spec.ts
View File

@ -26,16 +26,13 @@ describe("ExtendedPatronAttributes", () => {
});
});
afterEach(
() =>
function () {
cleanup();
cy.set_syspref(
"ExtendedPatronAttributes",
this.syspref_ExtendedPatronAttributes
);
}
);
afterEach(function () {
cleanup();
cy.set_syspref(
"ExtendedPatronAttributes",
this.syspref_ExtendedPatronAttributes
);
});
const table_id = "memberresultst";