From 98b97ea0758cb79dfcc465e25df416e4ed492c4e Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 15 Jul 2025 11:05:52 +0200 Subject: [PATCH] Bug 40372: Remove warning from api/v1/holds.t t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. We do not test the notification here, we can simply ignore the letters code Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass (cherry picked from commit c14e72e782e3a41a8463a12ded8bc2deca9271ae) Signed-off-by: Paul Derscheid --- t/db_dependent/api/v1/holds.t | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t index 9f13cb3a4d..728de95644 100755 --- a/t/db_dependent/api/v1/holds.t +++ b/t/db_dependent/api/v1/holds.t @@ -17,7 +17,8 @@ use Modern::Perl; -use Test::More tests => 16; +use Test::More tests => 17; +use Test::NoWarnings; use Test::MockModule; use Test::Mojo; use t::lib::TestBuilder; @@ -199,6 +200,10 @@ subtest "Test endpoints with permission" => sub { plan tests => 45; + # Prevent warning 'No reserves HOLD_CANCELLATION letter transported by email' + my $mock_letters = Test::MockModule->new('C4::Letters'); + $mock_letters->mock( 'GetPreparedLetter', sub { return } ); + $t->get_ok("//$userid_1:$password@/api/v1/holds")->status_is(200)->json_has('/0')->json_has('/1')->json_hasnt('/2'); $t->get_ok("//$userid_1:$password@/api/v1/holds?priority=2")->status_is(200)