gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 29754: (QA follow-up) Minor tests tweaks 

This patch does two things:

- Wraps the new SIP tests in a single transaction. We do that to avoid
  sub-test interference, specially when test files get big. The provided
  tests are correct and don't require previous tests data.
- Migrated from the introduced 'diag' calls to 'note', as I just learned
  they are the same, but 'note' is only displayed when in verbose mode.
  Which is great to avoid unnecessary noise in Jenkins.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0f0bfcad7c)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 190c925997)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
This commit is contained in:
Tomas Cohen Arazi 2022-02-07 08:58:43 -03:00 committed by Victor Grousset/tuxayo
parent 727376cdca
commit 97a59bd8d3
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/db_dependent/Koha/Patron.t
View File

@ -132,7 +132,7 @@ subtest 'relationships_debt() tests' => sub {
sub _test_combinations {
my ( $patrons, $parent1_debt, $parent2_debt, $child1_debt, $child2_debt ) = @_;
diag("Testing with parent 1 debt $parent1_debt | Parent 2 debt $parent2_debt | Child 1 debt $child1_debt | Child 2 debt $child2_debt");
note("Testing with parent 1 debt $parent1_debt | Parent 2 debt $parent2_debt | Child 1 debt $child1_debt | Child 2 debt $child2_debt");
# Options
# P1 => P1 + C1 + C2 ( - P1 ) ( + P2 )
# P2 => P2 + C1 + C2 ( - P2 ) ( + P1 )
@ -143,7 +143,7 @@ sub _test_combinations {
for my $i ( 0 .. 7 ) {
my ( $only_this_guarantor, $include_guarantors, $include_this_patron )
= split '', sprintf( "%03b", $i );
diag("---------------------");
note("---------------------");
for my $patron ( @$patrons ) {
if ( $only_this_guarantor
&& !$patron->guarantee_relationships->count )

6
t/db_dependent/SIP/Patron.t
View File

@ -272,12 +272,16 @@ subtest "fine_items tests" => sub {
is( @$fine_items, 0, "Got zero fine items" );
};
$schema->storage->txn_rollback;
subtest "NoIssuesChargeGuarantorsWithGuarantees tests" => sub {
plan tests => 1;
t::lib::Mocks::mock_preference( 'borrowerRelationship', 'parent' );
$schema->storage->txn_begin;
my $patron = $builder->build_object({ class => 'Koha::Patrons' });
my $child = $builder->build_object({ class => 'Koha::Patrons' });
$child->add_guarantor({ guarantor_id => $patron->borrowernumber, relationship => 'parent' });
@ -308,5 +312,5 @@ subtest "NoIssuesChargeGuarantorsWithGuarantees tests" => sub {
is( $sip_patron->fines_amount, 11.11,"Guarantee fines correctly included");
$schema->storage->txn_rollback;
};
$schema->storage->txn_rollback;