gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41070: Fix selector in addorderiso validator 

Steps to reproduce, do not apply patch
1 - Go to any record and click save -> marc (Unicode/utf8)
2 - Go to any vendor and add a basket
3 - In your acquisition grid, make sure "barcode" is mandatory
4 - In this basket, create a new order from file, use the generated file and wait for the end of the import. Click on add staged files to basket.
5 - Select the record, make sure no Fund or barcode is filled, neither in first or third tab.
6 - Validate: There will be an error due to the missing barcode. If
there is another error, fill the missing part of the form.
7 - Apply patch, repeat 6, the error will be due to the missing fund
8 - Select a fund in the first panel -> the error will be due to the
missing barcode
9 - Select a fund in the third panel -> the error will be due to the
missing barcode

Note: the point about the barcode are not relevant for the bug, they are
just here to prevent the submission of the form. And avoid repeating
steps 4-5.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Baptiste 2026-02-11 10:56:48 +01:00 committed by Lucas Gass
parent 539e160383
commit 956b039907
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
View File

@ -125,9 +125,9 @@ function checkOrderBudgets() {
var unset_funds = 0;
var all_budget_id = $("#all_budget_id");
// If we don't have an overarching default set we need to check each selected order
if (!all_budget_id.val()) {
$("fieldset.biblio.rows.order-selected").each(function () {
var default_order_fund = $(this).find("[name='budget_id']");
if ( !all_budget_id.val() ) {
$(".biblio .order-selected fieldset.rows").each(function(){
var default_order_fund = $(this).find("[name^='budget_id']");
// For each order we see if budget is set for order
if (!default_order_fund.val()) {
$(this).find(".item_fund.required").show();