gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 36536: Unit tests 

This patch introduces tests for the feature enabling patron's `lastseen`
attribute be updated when a successful password validation happens
through the API.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/password_validation.t
=> FAIL: Tests fail! The feature is not implemented!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit bab2635f5b)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Tomas Cohen Arazi 2025-08-29 09:57:49 -03:00 committed by Paul Derscheid
parent afb9c9c531
commit 91db420099
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
t/db_dependent/api/v1/password_validation.t
View File

@ -129,7 +129,7 @@ subtest 'password validation - unauthenticated user' => sub {
subtest 'Password validation - authorized requests tests' => sub {
plan tests => 24;
plan tests => 25;
$schema->storage->txn_begin;
@ -216,6 +216,55 @@ subtest 'Password validation - authorized requests tests' => sub {
->status_is( 400, 'Passing both parameters forbidden' )
->json_is( { error => 'Bad request. Only one identifier attribute can be passed.' } );
subtest 'TrackLastPatronActivityTriggers tests' => sub {
plan tests => 9;
my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { lastseen => undef } } );
my $patron_password = 'thePassword123';
$patron->set_password( { password => $patron_password, skip_validation => 1 } );
# to avoid interference
t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 99 );
# api_verify disabled
t::lib::Mocks::mock_preference( 'TrackLastPatronActivityTriggers', 'login' );
$patron->lastseen(undef)->store();
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json =>
{ identifier => $patron->userid, password => $patron_password } )->status_is( 201, 'Validation works' );
# read patron from the DB
$patron->discard_changes();
is(
$patron->lastseen, undef,
"'lastseen' flag untouched if no 'api_verify' in TrackLastPatronActivityTriggers"
);
# good scenario
t::lib::Mocks::mock_preference( 'TrackLastPatronActivityTriggers', 'api_verify' );
$patron->lastseen(undef)->store();
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json =>
{ identifier => $patron->userid, password => 'wrong password :-D' } )
->status_is( 400, 'Validation failed due to bad password' );
# read patron from the DB
$patron->discard_changes();
is( $patron->lastseen, undef, "'lastseen' flag not updated as validation failed" );
$patron->lastseen(undef)->store();
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json =>
{ identifier => $patron->userid, password => $patron_password } )->status_is( 201, 'Validation works' );
# read patron from the DB
$patron->discard_changes();
ok(
$patron->lastseen,
"'lastseen' flag updated TrackLastPatronActivityTriggers includes 'api_verify'"
);
};
$schema->storage->txn_rollback;
};