gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42083: (QA follow-up) Simplify atomicupdate migration loop 

Replace the O(n²) accumulate-and-re-insert pattern with a simple
per-row execute inside the while loop.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
This commit is contained in:
Martin Renvoize 2026-03-24 09:19:43 +01:00
parent 3dd4691076
commit 8eec766b5a
No known key found for this signature in database
GPG Key ID: 2D86E0EAEC83711B
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
installer/data/mysql/atomicupdate/Bug_42083_add_send_sms_permission.pl
View File

@ -9,12 +9,12 @@ return {
my ( $dbh, $out ) = @$args{qw(dbh out)};
$dbh->do(
q{INSERT IGNORE permissions (module_bit, code, description) VALUES (4, 'send_messages_to_borrowers_email', 'Send messages to patrons via email')}
q{INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (4, 'send_messages_to_borrowers_email', 'Send messages to patrons via email')}
);
say_success( $out, "Added new permission 'send_messages_to_borrowers_email'" );
$dbh->do(
q{INSERT IGNORE permissions (module_bit, code, description) VALUES (4, 'send_messages_to_borrowers_sms', 'Send messages to patrons via sms')}
q{INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (4, 'send_messages_to_borrowers_sms', 'Send messages to patrons via sms')}
);
say_success( $out, "Added new permission 'send_messages_to_borrowers_sms'" );
@ -25,12 +25,8 @@ return {
$dbh->prepare("SELECT borrowernumber FROM user_permissions WHERE code = 'send_messages_to_borrowers'");
$sth->execute();
my @borrowernumbers;
while ( my ($borrowernumber) = $sth->fetchrow_array() ) {
push @borrowernumbers, $borrowernumber;
my @rows_to_insert = ( map { [ $_, 4, "send_messages_to_borrowers_email" ] } @borrowernumbers );
foreach my $row (@rows_to_insert) { $insert_sth->execute( @{$row} ); }
$insert_sth->execute( $borrowernumber, 4, 'send_messages_to_borrowers_email' );
}
say_success( $out, "send_messages_to_borrowers_email added to all borrowers with send_messages_to_borrowers" );