gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41456: Rename more item_type => item_type_id in hold's api spec 

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f47ab213fd)
Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk>
This commit is contained in:
Jonathan Druart 2026-01-05 16:32:52 +01:00 committed by Jacob O'Mara
parent a97137a9d2
commit 8e87a7fa5c
No known key found for this signature in database
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Koha/REST/V1/Holds.pm
View File

@ -81,7 +81,7 @@ sub add {
my $pickup_library_id = $body->{pickup_library_id};
my $item_id = $body->{item_id};
my $patron_id = $body->{patron_id};
my $item_type = $body->{item_type};
my $item_type_id = $body->{item_type_id};
my $expiration_date = $body->{expiration_date};
my $notes = $body->{notes};
my $hold_date = $body->{hold_date};
@ -209,7 +209,7 @@ sub add {
title => $biblio->title,
itemnumber => $item_id,
found => undef, # TODO: Why not?
itemtype => $item_type,
itemtype => $item_type_id,
non_priority => $non_priority,
item_group_id => $item_group_id,
confirmations => $confirmations,

2
api/v1/swagger/paths/holds.yaml
View File

@ -201,7 +201,7 @@
type:
- string
- "null"
item_type:
item_type_id:
description: Limit hold on one itemtype (ignored for item-level holds)
type:
- string

6
t/db_dependent/api/v1/holds.t
View File

@ -277,7 +277,7 @@ subtest 'Reserves with itemtype' => sub {
patron_id => int( $patron_1->borrowernumber ),
biblio_id => int( $biblio_1->biblionumber ),
pickup_library_id => $branchcode,
item_type => $itemtype,
item_type_id => $itemtype,
};
$t->delete_ok("//$userid_3:$password@/api/v1/holds/$reserve_id")->status_is( 204, 'REST3.2.4' )
@ -294,7 +294,7 @@ subtest 'Reserves with itemtype' => sub {
$reserve_id = $t->tx->res->json->{hold_id};
$t->get_ok( "//$userid_1:$password@/api/v1/holds?patron_id=" . $patron_1->borrowernumber )->status_is(200)
->json_is( '/0/hold_id', $reserve_id )->json_is( '/0/item_type', $itemtype );
->json_is( '/0/hold_id', $reserve_id )->json_is( '/0/item_type_id', $itemtype );
};
subtest 'test AllowHoldDateInFuture' => sub {
@ -769,7 +769,7 @@ subtest 'add() tests (maxreserves behaviour)' => sub {
patron_id => $patron->borrowernumber,
biblio_id => $biblio_1->biblionumber,
pickup_library_id => $item_1->home_branch->branchcode,
item_type => $item_1->itype,
item_type_id => $item_1->itype,
};
$t->post_ok( "//$userid:$password@/api/v1/holds" => json => $post_data )->status_is(201);