Bug 33484: Add tables_settings.default_save_state_search

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

admin/columns_settings.yml

@@ -116,6 +116,7 @@ modules:
 
     parcel:
       pending_orders:
+        default_save_state_search: 1
         columns:
             -
               columnname: checkbox
@@ -213,6 +214,7 @@ modules:
 
     suggestions:
       suggestions:
+        default_save_state_search: 1
         columns:
             -
               columnname: selections
@@ -1960,6 +1962,7 @@ modules:
       circ-overdues:
         default_display_length: 20
         default_sort_order: 0
+        default_save_state_search: 1
         columns:
             -
               columnname: due_date

installer/data/mysql/atomicupdate/bug_33484.pl

@@ -13,5 +13,12 @@ return {
             });
             say $out "Added column 'tables_settings.default_save_state'";
         }
+        if ( !column_exists( 'tables_settings', 'default_save_state_search' ) ) {
+            $dbh->do(q{
+                ALTER TABLE tables_settings
+                  ADD COLUMN default_save_state_search tinyint(1) DEFAULT 0 AFTER default_save_state
+            });
+            say $out "Added column 'tables_settings.default_save_state_search'";
+        }
     },
 };

installer/data/mysql/kohastructure.sql

@@ -6297,6 +6297,7 @@ CREATE TABLE `tables_settings` (
   `default_display_length` smallint(6) DEFAULT NULL,
   `default_sort_order` varchar(255) DEFAULT NULL,
   `default_save_state` tinyint(1) DEFAULT 1,
+  `default_save_state_search` tinyint(1) DEFAULT 0,
   PRIMARY KEY (`module`(191),`page`(191),`tablename`(191))
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
 /*!40101 SET character_set_client = @saved_cs_client */;

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt

@@ -374,7 +374,7 @@
 
             if ( $("#receivedt").length ) {
                 var receivedt = $("#receivedt").dataTable($.extend(true, {}, dataTablesDefaults, {
-                    "stateSave": true,
+                    "stateSave": true, // We do not have table settings on this table
                     "pageLength": 10,
                     "lengthMenu": [[5, 10, 20, 50, 100, -1], [5, 10, 20, 50, 100, _("All")]],
                     "columnDefs": [
@@ -413,7 +413,6 @@
                     "current_item_level_holds+count",
                     "items"
                 ],
-                "stateSave": true, // remember state on page reload
                 "columns": [
                     { "data": "basket.name",
                       "searchable": true,

koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt

@@ -339,7 +339,6 @@
             KohaTable("overduest", {
                 "pagingType": "full",
                 "autoWidth": false,
-                "stateSave": true
             }, table_settings);
 
             $("#showall").on("change", function(){