From 8cf43dc2f99809a929f40f83e2c9b3114013b521 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Mon, 12 May 2025 13:29:23 +0000 Subject: [PATCH] Bug 39875: Add tests Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass (cherry picked from commit ae2e9e23de0d68874563b55ea3a7a816d8b5fb41) Signed-off-by: Paul Derscheid --- .../Koha/ILL/Request/Workflow/HistoryCheck.t | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t index 12796830b0..0bbcf31539 100755 --- a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t +++ b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t @@ -35,7 +35,7 @@ my $isbn = '321321321'; subtest 'show_history_check' => sub { - plan tests => 6; + plan tests => 7; $schema->storage->txn_begin; @@ -103,6 +103,22 @@ subtest 'show_history_check' => sub { 1, 'Request with ISBN ' . $isbn . ' exists, syspref is on and is same patron. Able to show history check screen' ); + my $metadata_with_no_cardnumber = { + title => 'This is a title', + author => 'This is an author', + isbn => $isbn, + }; + + my $ill_request_with_no_borrowernumber = $builder->build_sample_ill_request( { borrowernumber => undef } ); + + my $new_opac_history_check = + Koha::ILL::Request::Workflow::HistoryCheck->new( $metadata_with_no_cardnumber, 'staff' ); + + is( + $new_opac_history_check->show_history_check($ill_request_with_no_borrowernumber), + 0, 'Don\'t show history check for unauthenticated requests' + ); + # Mock ILLHistoryCheck disabled t::lib::Mocks::mock_preference( 'ILLHistoryCheck', 0 );