gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 17846: Remove C4::Koha::get_infos_of 

This subroutine does not longer make any senses. The call to
get_infos_of can be replaced with $dbh->selectall_hashref.
The third argument of this subroutine was never used.

Test plan (for developer only):
Compare the 2 codes and confirm that they are equivalent

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2017-01-04 12:39:18 +01:00 committed by Kyle M Hall
parent 2877575ae0
commit 8c8b17b114
3 changed files with 4 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
C4/Biblio.pm
View File

@ -1052,6 +1052,7 @@ sub GetBiblioItemInfosOf {
my $biblioitemnumber_values = @biblioitemnumbers ? join( ',', @biblioitemnumbers ) : "''";
my $dbh = C4::Context->dbh;
my $query = "
SELECT biblioitemnumber,
publicationyear,
@ -1059,7 +1060,7 @@ sub GetBiblioItemInfosOf {
FROM biblioitems
WHERE biblioitemnumber IN ($biblioitemnumber_values)
";
return get_infos_of( $query, 'biblioitemnumber' );
return $dbh->selectall_hashref($query, 'biblioitemnumber');
}
=head1 FUNCTIONS FOR HANDLING MARC MANAGEMENT

3
C4/Items.pm
View File

@ -1200,12 +1200,13 @@ sub GetItemInfosOf {
my $itemnumber_values = @itemnumbers ? join( ',', @itemnumbers ) : "''";
my $dbh = C4::Context->dbh;
my $query = "
SELECT *
FROM items
WHERE itemnumber IN ($itemnumber_values)
";
return get_infos_of( $query, 'itemnumber' );
return $dbh->selectall_hashref($query, 'itemnumber');
}
=head2 GetItemsByBiblioitemnumber

48
C4/Koha.pm
View File

@ -638,54 +638,6 @@ sub getFacets {
return $facets;
}
=head2 get_infos_of
Return a href where a key is associated to a href. You give a query,
the name of the key among the fields returned by the query. If you
also give as third argument the name of the value, the function
returns a href of scalar. The optional 4th argument is an arrayref of
items passed to the C<execute()> call. It is designed to bind
parameters to any placeholders in your SQL.
my $query = '
SELECT itemnumber,
notforloan,
barcode
FROM items
';
# generic href of any information on the item, href of href.
my $iteminfos_of = get_infos_of($query, 'itemnumber');
print $iteminfos_of->{$itemnumber}{barcode};
# specific information, href of scalar
my $barcode_of_item = get_infos_of($query, 'itemnumber', 'barcode');
print $barcode_of_item->{$itemnumber};
=cut
sub get_infos_of {
my ( $query, $key_name, $value_name, $bind_params ) = @_;
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare($query);
$sth->execute( @$bind_params );
my %infos_of;
while ( my $row = $sth->fetchrow_hashref ) {
if ( defined $value_name ) {
$infos_of{ $row->{$key_name} } = $row->{$value_name};
}
else {
$infos_of{ $row->{$key_name} } = $row;
}
}
$sth->finish;
return \%infos_of;
}
=head2 get_notforloan_label_of
my $notforloan_label_of = get_notforloan_label_of();