gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 10190: Deprecate permission 

user_permissions rows do not need manual cleanup because the FK on
user_permissions(module_bit, code) references permissions(module_bit, code)
ON DELETE CASCADE, so deleting from permissions automatically removes
per-patron rows.

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Chloe Zermatten 2026-02-25 09:37:30 +00:00 committed by Pedro Amorim
parent 564f15ca59
commit 8c8160761d
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
5 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
installer/data/mysql/atomicupdate/bug_10190.pl
View File

@ -13,6 +13,12 @@ return {
exit;
}
# Remove the tools sub-permission for notice triggers; access is now
# controlled by parameters/manage_circ_rules instead.
# user_permissions rows are cleaned up automatically via ON DELETE CASCADE.
$dbh->do(q|DELETE FROM permissions WHERE code = 'edit_notice_status_triggers'|);
say_success( $out, "Removed deprecated permission 'edit_notice_status_triggers'" );
# Populate empty overduerules table for missing categories
$dbh->do(
q|

3
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
View File

@ -404,9 +404,6 @@
[%- CASE 'edit_additional_contents' -%]
<span class="sub_permission edit_additional_contents_subpermission"> Write additional contents for the OPAC and staff interfaces (news and HTML customizations) </span>
<span class="permissioncode">([% name | html %])</span>
[%- CASE 'edit_notice_status_triggers' -%]
<span class="sub_permission edit_notice_status_triggers_subpermission"> Set notice/status triggers for overdue items </span>
<span class="permissioncode">([% name | html %])</span>
[%- CASE 'edit_notices' -%]
<span class="sub_permission edit_notices_subpermission"> Define notices </span>
<span class="permissioncode">([% name | html %])</span>

5
koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
View File

@ -6,7 +6,7 @@
<ul>
<li><a href="/cgi-bin/koha/tools/tools-home.pl">Tools home</a></li>
</ul>
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || CAN_user_tools_batch_modify_holds || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) || CAN_user_tools_rotating_collections ) %]
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || CAN_user_tools_batch_modify_holds || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) || CAN_user_tools_rotating_collections ) %]
<h5>Patrons and circulation</h5>
<ul>
[% IF ( CAN_user_tools_manage_patron_lists ) %]
@ -24,9 +24,6 @@
[% IF ( CAN_user_tools_edit_notices ) %]
<li><a href="/cgi-bin/koha/tools/letter.pl">Notices and slips</a></li>
[% END %]
[% IF ( CAN_user_tools_edit_notice_status_triggers ) %]
<li><a href="/cgi-bin/koha/admin/circulation_triggers">Overdue notice/status triggers</a></li>
[% END %]
[% IF ( CAN_user_tools_label_creator ) %]
<li><a href="/cgi-bin/koha/patroncards/home.pl">Patron card creator</a></li>
[% END %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
View File

@ -29,7 +29,7 @@
<h1>Tools</h1>
<div class="row">
<div class="col-sm-6">
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || ( CAN_user_tools_batch_modify_holds && CAN_user_reserveforothers_place_holds ) || CAN_user_tools_moderate_tags || CAN_user_tools_rotating_collections || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %]
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || ( CAN_user_tools_batch_modify_holds && CAN_user_reserveforothers_place_holds ) || CAN_user_tools_moderate_tags || CAN_user_tools_rotating_collections || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %]
<h3>Patrons and circulation</h3>
[% END %]
<dl>

1
t/Koha/Auth/Permissions.t
View File

@ -273,7 +273,6 @@ subtest 'superlibrarian tests' => sub {
'CAN_user_tools_delete_anonymize_patrons' => 1,
'CAN_user_tools_edit_additional_contents' => 1,
'CAN_user_tools_edit_calendar' => 1,
'CAN_user_tools_edit_notice_status_triggers' => 1,
'CAN_user_tools_edit_notices' => 1,
'CAN_user_tools_edit_patrons' => 1,
'CAN_user_tools_edit_quotes' => 1,