gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 39600: Add tests for patron_list 

Sponsored-by: Wiko <https://www.wiko-berlin.de/>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Tadeusz „tadzik” Sośnierz 2025-04-10 15:34:26 +02:00 committed by Katrin Fischer
parent 4929170536
commit 88dbb07620
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 81 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
t/db_dependent/api/v1/ill_requests.t
View File

@ -18,7 +18,7 @@
use Modern::Perl;
use Test::NoWarnings;
use Test::More tests => 3;
use Test::More tests => 4;
use Test::MockModule;
use Test::MockObject;
@ -264,6 +264,86 @@ subtest 'list() tests' => sub {
$schema->storage->txn_rollback;
};
subtest 'patron_list() tests' => sub {
plan tests => 15;
# Mock ILLBackend (as object)
my $backend = Test::MockObject->new;
$backend->set_isa('Koha::Illbackends::Mock');
$backend->set_always( 'name', 'Mock' );
$backend->mock(
'status_graph', sub { },
);
# Mock Koha::ILL::Request::load_backend (to load Mocked Backend)
my $illreqmodule = Test::MockModule->new('Koha::ILL::Request');
$illreqmodule->mock(
'load_backend',
sub { my $self = shift; $self->{_my_backend} = $backend; return $self }
);
$schema->storage->txn_begin;
Koha::ILL::Requests->search->delete;
my $requester = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 0 }
}
);
my $password = 'thePassword123';
$requester->set_password( { password => $password, skip_validation => 1 } );
my $requester_userid = $requester->userid;
my $requester_number = $requester->borrowernumber;
my $observer = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 0 }
}
);
$observer->set_password( { password => $password, skip_validation => 1 } );
my $observer_userid = $observer->userid;
my $observer_number = $observer->borrowernumber;
# No requests yet, expect empty for both
$t->get_ok("//$requester_userid:$password@/api/v1/patrons/$requester_number/ill/requests")->status_is(200)->json_is( [] );
$t->get_ok("//$observer_userid:$password@/api/v1/patrons/$observer_number/ill/requests")->status_is(200)->json_is( [] );
for (0..25) {
$builder->build_object(
{
class => 'Koha::ILL::Requests',
value => {
borrowernumber => $requester_number,
batch_id => undef,
status => 'NEW',
backend => $backend->name,
notesstaff => 'secret staff notes'
}
}
);
}
# Other user should not see anything
$t->get_ok("//$observer_userid:$password@/api/v1/patrons/$observer_number/ill/requests")->status_is(200)->json_is( [] );
# Staff notes hidden in the public API
$t->get_ok("//$requester_userid:$password@/api/v1/patrons/$requester_number/ill/requests")->status_is(200)->json_is(
'/0/staff_notes' => undef,
);
# Not all requests get returned, pagination works
$t->get_ok("//$requester_userid:$password@/api/v1/patrons/$requester_number/ill/requests")->status_is(200)->json_is(
'/21' => undef,
);
$schema->storage->txn_rollback;
};
subtest 'add() tests' => sub {
plan tests => 2;