diff --git a/Koha/Patron.pm b/Koha/Patron.pm
index acbe77fa3b..479eb3c209 100644
--- a/Koha/Patron.pm
+++ b/Koha/Patron.pm
@@ -838,7 +838,7 @@ Return 1 if Koha needs to perform PrevIssue checking, else 0.
=cut
sub wants_check_for_previous_checkout {
- my ($self, $item) = @_;
+ my ( $self, $item ) = @_;
my $syspref = C4::Context->preference("checkPrevCheckout");
# Simple cases
diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl
index 172fe249b1..1acc49bdd5 100755
--- a/admin/itemtypes.pl
+++ b/admin/itemtypes.pl
@@ -99,7 +99,6 @@ if ( $op eq 'add_form' ) {
my $rentalcharge_hourly_calendar = $input->param('rentalcharge_hourly_calendar') // 0;
my $automatic_checkin = $input->param('automatic_checkin') // 0;
my $bookable = $input->param('bookable') // 0;
- my $automatic_checkin = $input->param('automatic_checkin') // 0;
my $checkprevcheckout = $input->param('checkprevcheckout');
if ( $itemtype and $is_a_modif ) { # it's a modification
diff --git a/installer/data/mysql/atomicupdate/bug_20644-add_checkprevcheckout_to_items.pl b/installer/data/mysql/atomicupdate/bug_20644-add_checkprevcheckout_to_items.pl
index 9e975facbf..d09e1f1e53 100755
--- a/installer/data/mysql/atomicupdate/bug_20644-add_checkprevcheckout_to_items.pl
+++ b/installer/data/mysql/atomicupdate/bug_20644-add_checkprevcheckout_to_items.pl
@@ -7,7 +7,7 @@ return {
my ($args) = @_;
my ( $dbh, $out ) = @$args{qw(dbh out)};
- if( !column_exists( 'itemtypes', 'checkprevcheckout' ) ) {
+ if ( !column_exists( 'itemtypes', 'checkprevcheckout' ) ) {
$dbh->do(
q{
ALTER TABLE itemtypes
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
index 585ad224ed..f442006b24 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
@@ -362,17 +362,17 @@
diff --git a/t/db_dependent/Patron/Borrower_PrevCheckout.t b/t/db_dependent/Patron/Borrower_PrevCheckout.t
index c8d3ab0fc5..ac9b054876 100755
--- a/t/db_dependent/Patron/Borrower_PrevCheckout.t
+++ b/t/db_dependent/Patron/Borrower_PrevCheckout.t
@@ -49,26 +49,32 @@ my $inheritCatCode = $builder->build(
}
);
-my $yesItypeCode = $builder->build_object({
- class => 'Koha::ItemTypes',
- value => {
- checkprevcheckout => 'yes',
+my $yesItypeCode = $builder->build_object(
+ {
+ class => 'Koha::ItemTypes',
+ value => {
+ checkprevcheckout => 'yes',
+ }
}
-});
+);
-my $noItypeCode = $builder->build_object({
- class => 'Koha::ItemTypes',
- value => {
- checkprevcheckout => 'no',
+my $noItypeCode = $builder->build_object(
+ {
+ class => 'Koha::ItemTypes',
+ value => {
+ checkprevcheckout => 'no',
+ }
}
-});
+);
-my $inheritItypeCode = $builder->build_object({
- class => 'Koha::ItemTypes',
- value => {
- checkprevcheckout => 'inherit',
+my $inheritItypeCode = $builder->build_object(
+ {
+ class => 'Koha::ItemTypes',
+ value => {
+ checkprevcheckout => 'inherit',
+ }
}
-});
+);
# Create context for some tests late on in the file.
my $library = $builder->build( { source => 'Branch' } );
@@ -235,7 +241,6 @@ map {
} @{ $_->{categories} };
} @{$mappings};
-
# wants_check_for_previous_checkout
# We want to test the subroutine by passing the $item parameter
@@ -288,29 +293,29 @@ map {
# | Expected Result | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
my $itypeCode = {
- 'yes' => $yesItypeCode->itemtype,
- 'no' => $noItypeCode->itemtype,
+ 'yes' => $yesItypeCode->itemtype,
+ 'no' => $noItypeCode->itemtype,
'inherit' => $inheritItypeCode->itemtype,
};
-foreach my $syspref ('hardyes','softyes','softno','hardno'){
+foreach my $syspref ( 'hardyes', 'softyes', 'softno', 'hardno' ) {
t::lib::Mocks::mock_preference( 'checkprevcheckout', $syspref );
- foreach my $itemtype_setting ('yes','no','inherit'){ #itemtype Setting
- my $item = $builder->build_sample_item( { itype => $itypeCode->{$itemtype_setting} } );
- foreach my $categorie_settings('yes','no','inherit'){
+ foreach my $itemtype_setting ( 'yes', 'no', 'inherit' ) { #itemtype Setting
+ my $item = $builder->build_sample_item( { itype => $itypeCode->{$itemtype_setting} } );
+ foreach my $categorie_settings ( 'yes', 'no', 'inherit' ) {
my $catCode = $categorie_settings . 'Cat';
- foreach my $patron_setting('yes','no','inherit'){
+ foreach my $patron_setting ( 'yes', 'no', 'inherit' ) {
my $result = undef;
- $result = 1 if($syspref eq 'hardyes');
- $result = 0 if($syspref eq 'hardno');
- $result = 1 if(!defined $result && $itemtype_setting eq 'yes');
- $result = 0 if(!defined $result && $itemtype_setting eq 'no');
- $result = 1 if(!defined $result && $patron_setting eq 'yes');
- $result = 0 if(!defined $result && $patron_setting eq 'no');
- $result = 1 if(!defined $result && $categorie_settings eq 'yes');
- $result = 0 if(!defined $result && $categorie_settings eq 'no');
- $result = 1 if(!defined $result && $syspref eq 'softyes');
- $result = 0 if(!defined $result && $syspref eq 'softno');
+ $result = 1 if ( $syspref eq 'hardyes' );
+ $result = 0 if ( $syspref eq 'hardno' );
+ $result = 1 if ( !defined $result && $itemtype_setting eq 'yes' );
+ $result = 0 if ( !defined $result && $itemtype_setting eq 'no' );
+ $result = 1 if ( !defined $result && $patron_setting eq 'yes' );
+ $result = 0 if ( !defined $result && $patron_setting eq 'no' );
+ $result = 1 if ( !defined $result && $categorie_settings eq 'yes' );
+ $result = 0 if ( !defined $result && $categorie_settings eq 'no' );
+ $result = 1 if ( !defined $result && $syspref eq 'softyes' );
+ $result = 0 if ( !defined $result && $syspref eq 'softno' );
my $kpatron = $builder->build(
{
source => 'Borrower',