gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 9206: Followup QA FIX 

- Fix indentation
- It is useless to loop on all items. If at least 1 item is already
  issued, we want to return 1.
This commit is contained in:
Jonathan Druart 2012-12-26 14:52:52 +01:00 committed by Jared Camins-Esakov
parent e3f6a74660
commit 7fc4be502d
3 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
C4/Circulation.pm
View File

@ -83,7 +83,7 @@ BEGIN {
&GetBiblioIssues
&GetOpenIssue
&AnonymiseIssueHistory
&CheckIfIssuedToPatron
&CheckIfIssuedToPatron
);
# subs to deal with returns
@ -3455,16 +3455,15 @@ sub TransferSlip {
=cut
sub CheckIfIssuedToPatron {
my ($borrowernumber, $biblionumber) = @_;
my $isissued = 0;
my ($borrowernumber, $biblionumber) = @_;
my $items = GetItemsByBiblioitemnumber($biblionumber);
my $items = GetItemsByBiblioitemnumber($biblionumber);
foreach my $item (@{$items}) {
$isissued = 1 if ($item->{borrowernumber} && $item->{borrowernumber} eq $borrowernumber);
}
foreach my $item (@{$items}) {
return 1 if ($item->{borrowernumber} && $item->{borrowernumber} eq $borrowernumber);
}
return $isissued;
return;
}

12
koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
View File

@ -293,12 +293,12 @@
[% UNLESS ( bibitemloo.bib_available ) %]
<div class="bibmessage">No available items.</div>
[% ELSE %]
[% IF ( bibitemloo.already_patron_possession ) %]
<div class="bibmessage">This title cannot be requested because it's already in your possession.</div>
[% ELSE %]
<div class="bibmessage">This title cannot be requested.</div>
[% END %]
[% END %]
[% IF ( bibitemloo.already_patron_possession ) %]
<div class="bibmessage">This title cannot be requested because it's already in your possession.</div>
[% ELSE %]
<div class="bibmessage">This title cannot be requested.</div>
[% END %]
[% END %]
[% END %]

2
reserve/request.pl
View File

@ -244,7 +244,7 @@ foreach my $biblionumber (@biblionumbers) {
my $dat = GetBiblioData($biblionumber);
unless ( CanBookBeReserved($borrowerinfo->{borrowernumber}, $biblionumber) ) {
$warnings = 1;
$warnings = 1;
$maxreserves = 1;
}