gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40755: Fix typo in waiting_holds.inc 

Fix a typo that caused an error 500 on the holds awaiting pickup page
when there are holds with cancellation requests.

To test:
1. Enable hold cancellation requests from the OPAC
   i. Go to Administration > Circulation and Fines rules
   ii. In the "Default waiting hold cancellation policy" section, add the rule:
       All / All / Yes
2. Place at least two holds for pickup at the logged-in library (for ease of testing, place both holds for the same patron)
3. Check in items for both holds and confirm to set holds to Waiting
4. Log into the OPAC as the patron from step 2
5. Go to the patron's holds tab and request cancellation for both holds
6. In the staff interface, go to Circulation > Holds awaiting pickup
==> Error 500! :(
7. Apply patch and refresh the page
==> The page loads! :)

Bonus testing (KTD only):
1. Edit one of the cancellation request dates, so that they are not both
   the same date:
   ktd --shell
   koha-mysql kohadev
   SELECT * FROM hold_cancellation_requests;
   UPDATE hold_cancellation_requests SET creation_date=<date> WHERE hold_cancellation_request_id = <id>;
2. Refresh the Holds awaiting pickup page again, and switch to the Holds
   with cancellation requests tab
3. Sort by hold cancellation request date and confirm the sorting works
   correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 083db57f1e)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Emily Lamancusa 2025-09-04 09:37:37 -04:00 committed by Paul Derscheid
parent 11678357bb
commit 7bcca8e3aa
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc
View File

@ -30,7 +30,7 @@
<td data-order="[% reserveloo.reservedate | html %]"><span>[% reserveloo.reservedate | $KohaDates %]</span></td>
[% IF table_name == 'holdscr' %]
[% IF reserveloo.cancellation_requests.count %]
<td data-order="[% cancellation_request.0.creation_date | html %]">
<td data-order="[% cancellation_requests.0.creation_date | html %]">
[% FOREACH cancellation_request IN reserveloo.cancellation_requests %]
<span>[% cancellation_request.creation_date | $KohaDates %]</span>
[% END %]