gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 29788: (follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean 

There were several wrong things in the previous patch!

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Jonathan Druart 2022-03-23 12:30:42 +01:00 committed by Fridolin Somers
parent ed5250534e
commit 78ecdc8439
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Koha/BackgroundJob/BatchDeleteBiblio.pm
View File

@ -108,7 +108,7 @@ sub process {
my $items = Koha::Items->search({ biblionumber => $biblionumber });
while ( my $item = $items->next ) {
my $deleted = $item->safe_delete;
if( $deleted ) {
unless ( $deleted ) {
push @messages, {
type => 'error',
code => 'item_not_deleted',

12
cataloguing/additem.pl
View File

@ -377,11 +377,13 @@ if ($op eq "additem") {
# check that there is no issue on this item before deletion.
my $item = Koha::Items->find($itemnumber);
my $deleted = $item->safe_delete;
if($deleted) {
unless ( $deleted ) {
print $input->redirect("additem.pl?biblionumber=$biblionumber&frameworkcode=$frameworkcode&searchid=$searchid");
} else {
push @errors, @{$deleted->messages}[0]->message;
$nextop="additem";
exit;
}
else {
push @errors, @{ $deleted->messages }[0]->message;
$nextop = "additem";
}
#-------------------------------------------------------------------------------
} elsif ($op eq "delallitems") {
@ -389,7 +391,7 @@ if ($op eq "additem") {
my $items = Koha::Items->search({ biblionumber => $biblionumber });
while ( my $item = $items->next ) {
my $deleted = $item->safe_delete({ skip_record_index => 1 });
push @errors, @{$deleted->messages}[0]->message;
push @errors, @{$deleted->messages}[0]->message unless $deleted;
}
my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
$indexer->index_records( $biblionumber, "specialUpdate", "biblioserver" );