gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41135: Convert About page Perl module table to DataTable 

This patch updates the display of Perl modules on the About page,
showing them in a regular DataTable instead of a multi-column one. This
allows for sorting, filtering by required or missing, and searching.

To test, apply the patch and restart services.

- Go to the About page and click the "Perl modules" tab.
- The Perl modules should be displayed in a DataTable.
- Required modules are still shown in bold but now there is a column of
  with check marks for required modules so that you can sort or filter
  by required.
  - Test the "Show required" link at the top of the table and confirm
    that only required modules are shown.
- To test the display of Missing modules, uninstall at least one
  required module and at least one optional one, e.g.:

  > sudo dpkg --remove --force-depends libtest-mockmodule-perl libtest-mocktime-perl

- Restart services and return to the About page Perl modules list. Use
  the table filter form to search for "mock."
  - You should see the required module, Test::MockModule, with the
    status in red, "Required module missing."
  - The optional module, Test::MockTime, should have a yellow warning
    "Optional module missing."
- Clear the search form and click the "Show missing" link. The table
  should be filtered down to only those modules you removed.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2025-08-25 11:34:03 +00:00 committed by Lucas Gass
parent a762e68e0d
commit 77ee024313
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
2 changed files with 97 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
about.pl
View File

@ -654,29 +654,7 @@ if ( $tab eq 'perl' ) {
@components = sort { $a->{'name'} cmp $b->{'name'} } @components;
my $counter = 0;
my $row = [];
my $table = [];
foreach (@components) {
push( @$row, $_ );
unless ( ++$counter % 4 ) {
push( @$table, { row => $row } );
$row = [];
}
}
# Processing the last line (if there are any modules left)
if ( scalar(@$row) > 0 ) {
# Extending $row to the table size
$$row[3] = '';
# Pushing the last line
push( @$table, { row => $row } );
}
## ## $table
$template->param( table => $table );
$template->param( table => \@components );
}

134
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
View File

@ -17,6 +17,12 @@
.version-ellipsis {
text-decoration: underline;
}
#dt-info {
display: flex;
}
.filter_controls {
margin-top: 0.25em;
}
</style>
</head>
<body id="about_about" class="about">
@ -85,6 +91,39 @@
</div>
<!-- /.main.container-fluid -->
[% MACRO jsinclude BLOCK %]
[% INCLUDE 'datatables.inc' %]
<script>
$(document).ready(function () {
let perl_table = $("#perl_table").kohaTable({
autoWidth: false,
paging: false,
columns: [null, { width: "10%" }, { width: "10%" }, { width: "10%" }, null],
dom: '<"#dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"i>',
initComplete: function (settings, json) {
$("#dt-info").append(
'<div class="filter_controls"><a id="show_all" class="btn btn-link filter_table" href="#">Show all</a> | <a id="show_required_modules" class="btn btn-link filter_table" href="#"><i class="fa fa-asterisk"></i> Show required</a> | <a id="show_missing_modules" class="btn btn-link filter_table" href="#"><i class="fa fa-question"></i> Show missing</a></div>'
);
},
});
$("body").on("click", ".filter_table", function (e) {
e.preventDefault();
perl_table.DataTable().column(1).search("").draw();
perl_table.DataTable().column(4).search("").draw();
if ($(this)[0].id == "show_required_modules") {
perl_table.DataTable().column(1).search(1).draw();
} else if ($(this)[0].id == "show_missing_modules") {
perl_table.DataTable().column(4).search(1).draw();
} else {
perl_table.DataTable().column(1).search("").draw();
perl_table.DataTable().column(4).search("").draw();
}
});
});
</script>
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]
[% BLOCK about_panel %]
@ -275,51 +314,70 @@
[% BLOCK perl_panel %]
[% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
<table style="cursor:pointer">
<caption>Perl modules</caption>
[% FOREACH line IN table %]
<h2>Perl modules</h2>
<table id="perl_table" style="cursor:pointer">
<caption class="visually-hidden">Perl modules</caption>
<thead>
<tr>
[% FOREACH ro IN line.row %]
[% IF ( ro.require ) %]
[% SET th_font_weight = "bold" %]
<th>Module</th>
<th>Required</th>
<th>Current version</th>
<th>Minimum version</th>
<th>Status</th>
</tr>
</thead>
<tbody>
[% FOREACH line IN table %]
<tr>
<td>
[% IF ( line.require ) %]
<strong>[% line.name | html %]</strong>
[% ELSE %]
[% line.name | html %]
[% END %]
</td>
[% IF ( line.require ) %]
<td data-search="1" data-sort="1">
<i class="fa fa-check"></i>
</td>
[% ELSE %]
[% SET th_font_weight = "normal" %]
<td data-search="0" data-sort="0"></td>
[% END %]
[% IF ( ro.current ) %]
[% SET th_background_color = "" %]
[% SET th_title = t("Module current") %]
[% ELSIF ( ro.upgrade ) %]
[% SET th_background_color = "#FFCB2F" %]
[% SET th_title = t("Module upgrade needed") %]
[% ELSE %]
[% IF ( ro.require ) %]
[% SET th_background_color = "#FF8A8A" %]
[% SET th_title = t("Required module missing") %]
[% ELSIF ( ro.name != '' ) %]
[% SET th_background_color = "#FF8A8A" %]
[% SET th_title = t("Optional module missing") %]
[% END %]
[% END # /IF ro.current %]
<th scope="row" style="background-color:[% th_background_color | html %];font-weight:[% th_font_weight | html %];" title="[% th_title | html %]">
[% IF ( ro.name ) %]
[% ro.name | html %]
<span style="font-weight:normal; font-size:smaller">
([% ro.reqversion | html %]
[% IF ro.maxversion %]- [% ro.maxversion | html %][% END %]
[% IF ro.excversion %][% FOR v IN ro.excversion %], ![% v | html %][% END %][% END %])
</span>
[% END %]
</th>
[% IF ( ro.name == '' ) %]
[% IF ( line.name == '' ) %]
<td></td>
[% ELSIF ( ro.version ) %]
<td>[% ro.version | html %]</td>
[% ELSIF ( line.version ) %]
<td>[% line.version | html %]</td>
[% ELSE %]
<td style="font-weight:bold">Not Installed</td>
[% END %]
[% END # /FOREACH ro %]
</tr>
[% END # /FOREACH line %]
<td>
<span>
[% line.reqversion | html %]
[% IF line.maxversion %]- [% line.maxversion | html %][% END %]
[% IF line.excversion %]
[% FOR v IN line.excversion %]
, ![% v | html %]
[% END %]
[% END %]
</span>
</td>
<td [% IF ( !line.current && !line.upgrade ) %]data-search="1"[% ELSE %]data-search="0"[% END %]>
[% IF ( line.current ) %]
<span class="badge text-bg-info">Module current</span>
[% ELSIF ( line.upgrade ) %]
<span class="badge text-bg-info">Module upgrade needed</span>
[% ELSE %]
[% IF ( line.require ) %]
<span class="badge text-bg-danger">Required module missing</span>
[% ELSIF ( line.name != '' ) %]
<span class="badge text-bg-warning">Optional module missing</span>
[% END %]
[% END # /IF line.current %]
</td>
</tr>
[% END %]
</tbody>
</table>
[% END # tab=perl %]
[% END %]