gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38664: The tidy script - fix race condition - replace edit_file 

It seems that File::Slurp::edit_file is not thread safe?
Not sure what's happening here but I end up with corrupted file, or
getting the same error "write_file: No such file or directory"

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2025-01-09 13:30:47 +01:00 committed by Katrin Fischer
parent 4a7a8fbef1
commit 745da164ad
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
misc/devel/tidy.pl
View File

@ -3,7 +3,7 @@ use Modern::Perl;
use Getopt::Long;
use Pod::Usage;
use Try::Tiny;
use File::Slurp qw( edit_file );
use File::Slurp qw( read_file write_file );
use IPC::System::Simple qw( capture );
use IPC::Cmd qw( run );
use Parallel::ForkManager;
@ -135,17 +135,15 @@ sub tidy_tt {
my ( $success, $error_message, $full_buf, $stdout_buf, $stderr_buf );
for ( 1 .. 2 ) {
( $success, $error_message, $full_buf, $stdout_buf, $stderr_buf ) =
run( command => sprintf q{yarn --silent run prettier --write %s}, $file );
run( command => sprintf( q{yarn run prettier --write %s}, $file ) );
if ($success) {
while ( !-f $file ) { sleep 1; }
# Revert the substitutions done by the prettier plugin
edit_file sub {
s#<!--</head>-->#</head>#g;
s#<!--<body(.*)-->#<body$1#g;
s#<!--</body>-->#</body>#g;
}, $file;
my $content = read_file($file);
$content =~ s#<!--</head>-->#</head>#g;
$content =~ s#<!--<body(.*)-->#<body$1#g;
$content =~ s#<!--</body>-->#</body>#g;
write_file( $file, $content );
}
}
return ( $success, $error_message, $full_buf, $stdout_buf, $stderr_buf );