gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 35612: (QA follow-up) Use interface parameter and remove self-referential use 

This patch fixes two issues:

1. C4::Accounts::chargelostitem now properly uses the $interface
   variable that was set from $opts->{interface} instead of calling
   C4::Context->interface directly. This ensures the interface
   parameter is honored, particularly important for cronjob context.

2. Removes the self-referential 'use Koha::Checkout;' statement in
   Koha/Checkout.pm which is logically incorrect (a module should
   not use itself).

Test plan:
1. Run prove t/db_dependent/Accounts.t
2. Run prove t/db_dependent/Koha/Checkout.t
3. Verify all tests pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2026-02-05 08:11:14 +00:00 committed by Lucas Gass
parent b6695f75bd
commit 73ae8a15db
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
C4/Accounts.pm
View File

@ -140,7 +140,7 @@ sub chargelostitem {
description => $description,
note => $processingfeenote,
user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef,
interface => C4::Context->interface,
interface => $interface,
library_id => $library_id,
type => 'PROCESSING',
item_id => $itemnumber,
@ -157,7 +157,7 @@ sub chargelostitem {
description => $description,
note => undef,
user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef,
interface => C4::Context->interface,
interface => $interface,
library_id => $library_id,
type => 'LOST',
item_id => $itemnumber,

1
Koha/Checkout.pm
View File

@ -24,7 +24,6 @@ use DateTime;
use Try::Tiny qw( catch try );
use C4::Circulation qw( AddRenewal CanBookBeRenewed LostItem MarkIssueReturned );
use Koha::Checkout;
use Koha::Booking;
use Koha::Checkouts::Renewals;
use Koha::Checkouts::ReturnClaims;