Bug 29105: Add effective_itemtype handling to items api

This patch adds effective_item_type_id to the items api.

We overload the to_api method to append the effective_item_type_id field
with that of the effective itemtype code.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dc75b5d5cd)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f00a28b576)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>

Koha/Item.pm

@@ -1232,6 +1232,23 @@ sub public_read_list {
     ];
 }
 
+=head3 to_api
+
+Overloaded to_api method to ensure item-level itypes is adhered to.
+
+=cut
+
+sub to_api {
+    my ($self, $params) = @_;
+
+    my $response = $self->SUPER::to_api($params);
+    my $overrides = {};
+
+    $overrides->{effective_item_type_id} = $self->effective_itemtype;
+
+    return { %$response, %$overrides };
+}
+
 =head3 to_api_mapping
 
 This method returns the mapping for representing a Koha::Item object

api/v1/swagger/definitions/item.yaml

@@ -183,6 +183,11 @@ properties:
       - string
       - "null"
     description: Itemtype defining the type for this item
+  effective_item_type_id:
+    type:
+      - string
+      - "null"
+    description: Effective itemtype defining the type for this item_id
   extended_subfields:
     type:
       - string