Bug 20428: Display warning if the entry is empty

And not only if the entry is missing. We should do the same for other
entries.
Also, use Koha::UploadedFile->temporary_directory to know the fallback
value.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2018-05-14 11:11:34 -03:00
parent a88e052ae5
commit 71eba3a74a
2 changed files with 6 additions and 4 deletions

View File

@ -47,6 +47,7 @@ use Koha::Caches;
use Koha::Config::SysPrefs;
use Koha::Illrequest::Config;
use Koha::SearchEngine::Elasticsearch;
use Koha::UploadedFiles;
use C4::Members::Statistics;
@ -261,10 +262,11 @@ if ( ! defined C4::Context->config('upload_path') ) {
}
}
if ( ! defined C4::Context->config('tmp_path') ) {
if ( ! C4::Context->config('tmp_path') ) {
my $temporary_directory = Koha::UploadedFile->temporary_directory;
push @xml_config_warnings, {
error => 'tmp_path_entry_missing',
effective_tmp_dir => File::Spec->tmpdir
error => 'tmp_path_missing',
effective_tmp_dir => $temporary_directory,
}
}

View File

@ -414,7 +414,7 @@
Also note that you need to properly set the OPACBaseURL preference for the file upload plugin to work.
</td>
</tr>
[% ELSIF config_entry.error == 'tmp_path_entry_missing' %]
[% ELSIF config_entry.error == 'tmp_path_missing' %]
<tr>
<th scope="row"><b>Warning</b></th>
<td>You are missing the &lt;tmp_path&gt; entry in your koha-conf.xml file. Please