From 7077634044182d8bcfea24fccd4565980b2fbc8b Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 24 Mar 2026 12:17:41 +0100 Subject: [PATCH] Revert "Bug 41247: Improve ILL batches modal resetability" This reverts commit b591b668d29611fe6b9ece85cd7ec3e4293cae62. --- .../intranet-tmpl/prog/js/ill-batch-modal.js | 20 +++++-------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js b/koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js index 552541d570..1051c5a3ca 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js +++ b/koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js @@ -159,10 +159,11 @@ }); $("#ill-batch-modal").on("hidden.bs.modal", function () { // Reset our state when we close the modal + // TODO: need to also reset progress bar and already processed identifiers delete elId.dataset.batchId; delete elId.dataset.backend; batchId = null; - $("#identifier-table_wrapper").hide(); + tableEl.style.display = "none"; tableContent.data = []; progressTotals.data = { total: 0, @@ -172,8 +173,6 @@ textarea.value = ""; batch.data = {}; cancelButton.innerHTML = cancelButtonOriginalText; - hideProgress(); - hideErrors(); // Remove event listeners we created removeEventListeners(); }); @@ -193,13 +192,11 @@ isUpdate = true; setModalHeading(); finishButton.removeAttribute("disabled"); - hideCreateButton(); + createButton.style.display = "none"; } else { batch.data = emptyBatch; setModalHeading(); finishButton.style.display = "none"; - createButton.style.display = "inline-block"; - createButton.setAttribute("disabled", 1); } fetchStatuses(); finishButtonEventListener(); @@ -402,7 +399,7 @@ createButton.removeEventListener("click", createBatch); identifierTable.removeEventListener("click", toggleMetadata); identifierTable.removeEventListener("click", removeRow); - createRequestsButton.removeEventListener("click", requestRequestable); + createRequestsButton.remove("click", requestRequestable); } function finishButtonEventListener() { @@ -640,11 +637,6 @@ el.style.display = "block"; } - function hideProgress() { - var el = document.getElementById("create-progress"); - el.style.display = "none"; - } - function showCreateRequestsButton() { var data = progressTotals.data; var el = document.getElementById("create-requests"); @@ -737,8 +729,6 @@ // Now build and display the table if (!table) { buildTable(); - } else { - tableEl.parentElement.style.display = "block"; } // We may be appending new values to an existing table, @@ -793,7 +783,7 @@ } function hideCreateButton() { - createButton.style.display = "none"; + createButton.remove(); } async function populateMetadata(identifier) {