From 6fb28b55837e59f9882e920c8efc67a6c5e2fe4c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 11 Dec 2025 09:20:27 +0100 Subject: [PATCH] Bug 19690: Change comments in IsAvailableForItemLevelRequest The term 'If any unavailable' is not very clear but it is also very hard to find something short and better. A next available hold is possible when at least one item is unavailable (checked out, on order, waiting/transit hold). A item level hold is possible when the specific item is unavailable. Test plan: Read the patch. The code did not change. Signed-off-by: Marcel de Rooy Signed-off-by: Laura Escamilla --- C4/Reserves.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 5696ae7ad3..47c8220981 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1542,9 +1542,9 @@ sub IsAvailableForItemLevelRequest { my $on_shelf_holds = Koha::CirculationRules->get_onshelfholds_policy( { item => $item, patron => $patron } ); - if ( $on_shelf_holds == 1 ) { + if ( $on_shelf_holds == 1 ) { # Allow return 1; - } elsif ( $on_shelf_holds == 2 ) { + } elsif ( $on_shelf_holds == 2 ) { # If all unavailable # These calculations work at the biblio level, and can be expensive # we use the in-memory cache to avoid calling once per item when looping items on a biblio @@ -1560,7 +1560,7 @@ sub IsAvailableForItemLevelRequest { $memory_cache->set_in_cache( $cache_key, $any_available ); return $any_available ? 0 : 1; - } else { # on_shelf_holds == 0 "If any unavailable" (the description is rather cryptic and could still be improved) + } else { # on_shelf_holds == 0 [If any unavailable] return $item->notforloan < 0 || $item->onloan || $item->holds->filter_by_found->count; } }