From 6fa6228f7362eafec2b14da38e914e14eb8d65e3 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 26 May 2026 13:50:15 -0400 Subject: [PATCH] Bug 42695: Minor language and markup corrections to reports error messages This patch makes a vew minor corrections to guided_reports_start.tt. To test apply the patch and go to Reports. - Try to create an SQL report which uses UPDATE, e.g. UPDATE items SET barcode = 1 WHERE itemnumber = 1 - Confirm that the text of the error message reads well and is formatted well. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Lucas Gass --- .../modules/reports/guided_reports_start.tt | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index a1e8d5b8c4..45f29f1406 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1636,25 +1636,26 @@ [% IF ( errors ) %]
- The following error was encountered:
+

The following error was encountered:

[% FOREACH error IN errors %] [% IF ( error.duplicate_running_report ) %] - This report is already running. Please wait for it to finish before running it again. +

This report is already running. Please wait for it to finish before running it again.

[% ELSIF ( error.total_running_reports_limit_exceeded ) %] - You have too many reports running at the moment. Please wait for some of them to finish before running this report again. +

You have too many reports running at the moment. Please wait for some of them to finish before running this report again.

[% ELSIF ( error.sqlerr ) %] - This report contains the SQL keyword [% error.sqlerr | html %].
- Use of this keyword is not allowed in Koha reports due to security and data integrity risks. Only SELECT queries are allowed.
- Please return to the "Saved Reports" screen and delete this report or retry creating a new one. +

+ This report contains an SQL keyword: [% error.sqlerr | html %]. Use of this keyword is not allowed in Koha reports due to security and data integrity risks. Only SELECT queries are allowed. +

+

Please delete this report or retry creating a new one.

[% ELSIF ( error.queryerr ) %] - The database returned the following error:
- [% error.queryerr | html %]
Please check the log for further details. +

SQL error:

+

[% error.queryerr | html %]

+

Please check the log for further details.

[% ELSIF ( error.cache_expiry ) %] - Please select a cache expiry less than 30 days. +

Please select a cache expiry less than 30 days.

[% ELSIF ( error.passworderr ) %] - The column selection in this report includes a password field.
- The report cannot be executed due to security risks.
- Please edit this report and ensure no password columns have been selected. +

The column selection in this report includes a password field.

+

The report cannot be executed due to security risks. Please edit this report and ensure no password columns have been selected.

[% ELSE %] [% END %]