gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 34478: Add test to catch missing op in POST forms 

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2024-02-07 09:16:33 +01:00
parent 2c83be0309
commit 69b6069309
No known key found for this signature in database
GPG Key ID: A085E712BEF0E0F0
2 changed files with 81 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
xt/find-missing-csrf.t
View File

@ -1,6 +1,6 @@
#!/usr/bin/perl
# Copyright 2021 Koha development team
# Copyright 2024 Koha development team
#
# This file is part of Koha.
#
@ -19,39 +19,23 @@
use Modern::Perl;
use Test::More tests => 1;
use File::Find;
use File::Slurp;
use Data::Dumper;
my @themes;
# OPAC themes
my $opac_dir = 'koha-tmpl/opac-tmpl';
opendir ( my $dh, $opac_dir ) or die "can't opendir $opac_dir: $!";
for my $theme ( grep { not /^\.|lib|js|xslt/ } readdir($dh) ) {
push @themes, "$opac_dir/$theme/en";
}
close $dh;
# STAFF themes
my $staff_dir = 'koha-tmpl/intranet-tmpl';
opendir ( $dh, $staff_dir ) or die "can't opendir $staff_dir: $!";
for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
push @themes, "$staff_dir/$theme/en";
}
close $dh;
my @files;
sub wanted {
my $name = $File::Find::name;
push @files, $name
if $name =~ m[\.(tt|inc)$] and -f $name;
}
find({ wanted => \&wanted, no_chdir => 1 }, @themes );
# OPAC
push @files, `git ls-files 'koha-tmpl/opac-tmpl/bootstrap/en/*.tt'`;
push @files, `git ls-files 'koha-tmpl/opac-tmpl/bootstrap/en/*.inc'`;
# Staff
push @files, `git ls-files 'koha-tmpl/intranet-tmpl/prog/en/*.tt'`;
push @files, `git ls-files 'koha-tmpl/intranet-tmpl/prog/en/*.inc'`;
my @errors;
for my $file ( @files ) {
chomp $file;
my @e = check_csrf_in_forms($file);
push @errors, sprintf "%s:%s", $file, join (",", @e) if @e;
}

71
xt/find-missing-op-in-forms.t Executable file
View File

@ -0,0 +1,71 @@
#!/usr/bin/perl
# Copyright 2024 Koha development team
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 1;
use File::Slurp;
use Data::Dumper;
my @files;
# OPAC
push @files, `git ls-files 'koha-tmpl/opac-tmpl/bootstrap/en/*.tt'`;
push @files, `git ls-files 'koha-tmpl/opac-tmpl/bootstrap/en/*.inc'`;
# Staff
push @files, `git ls-files 'koha-tmpl/intranet-tmpl/prog/en/*.tt'`;
push @files, `git ls-files 'koha-tmpl/intranet-tmpl/prog/en/*.inc'`;
my @errors;
for my $file ( @files ) {
chomp $file;
my @e = catch_missing_op($file);
push @errors, sprintf "%s:%s", $file, join (",", @e) if @e;
}
is( @errors, 0, "The <form> in the following files are missing it's corresponding op parameter (see bug 34478)" )
or diag( Dumper @errors );
sub catch_missing_op {
my ($file) = @_;
my @lines = read_file($file);
my @errors;
return unless grep { $_ =~ m|<form| } @lines;
my ( $in_form, $closed_form, $line_open_form, $has_op );
my $line_number = 0;
for my $line (@lines) {
$line_number++;
if ( $line =~ m{^(\s*)<form.*method=('|")post('|")}i ) {
$in_form = 1;
$line_open_form = $line_number;
}
if ( $in_form && $line =~ m{name="op"} ) {
$has_op = 1;
}
if ( $in_form && $line =~ m{</form} ) {
$closed_form = 0;
unless ($has_op) {
push @errors, $line_open_form;
}
$in_form = 0;
}
}
return @errors;
}