gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 34838: Replace SUPER::AUTOLOAD with get_column 

I'm not 100% happy with this but I'm out of ideas.

I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously.

Test plan:
  prove t/db_dependent/Koha/Illbackend.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a9f6f47afb)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Pedro Amorim 2023-09-25 15:07:37 +00:00 committed by Lucas Gass
parent 647d5e9a9e
commit 6909c637bd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Koha/ILL/Request.pm
View File

@ -299,7 +299,7 @@ correct category and records the fact that the status has changed
sub status_alias {
my ($self, $new_status_alias) = @_;
my $current_status_alias = $self->SUPER::status_alias;
my $current_status_alias = $self->get_column('status_alias');
if ($new_status_alias) {
# Keep a record of the previous status before we change it,
@ -334,7 +334,7 @@ sub status_alias {
my $alias = Koha::AuthorisedValues->search(
{
category => 'ILL_STATUS_ALIAS',
authorised_value => $self->SUPER::status_alias
authorised_value => $current_status_alias
},
{},
$self->branchcode
@ -360,8 +360,8 @@ and sends a notice if appropriate
sub status {
my ( $self, $new_status) = @_;
my $current_status = $self->SUPER::status;
my $current_status_alias = $self->SUPER::status_alias;
my $current_status = $self->get_column('status');
my $current_status_alias = $self->get_column('status_alias');
if ($new_status) {
# Keep a record of the previous status before we change it,