From 681069596ac469d01775968eb40a0bce6723b1e5 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 17 Apr 2026 09:18:54 +0200 Subject: [PATCH] Bug 42254: (QA follow-up) Remove unused var, fixing a FIXME Test plan: Read the patch. Look for the var in the script. Signed-off-by: Marcel de Rooy Signed-off-by: Jacob O'Mara --- tags/review.pl | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tags/review.pl b/tags/review.pl index 18c06b10e7..bedb519113 100755 --- a/tags/review.pl +++ b/tags/review.pl @@ -46,7 +46,7 @@ sub ajax_auth_cgi { # returns CGI object my ($auth_status) = check_cookie_auth( $sessid, $needed_flags ); if ( $auth_status ne "ok" ) { - #FIMXE: This should return a HTTP error and not a script + #FIXME: This should return a HTTP error and not a script output_with_http_headers $input, undef, "window.alert('Your CGI session cookie ($sessid) is not current. " . "Please refresh the page and try again.');\n", 'js'; @@ -55,12 +55,11 @@ sub ajax_auth_cgi { # returns CGI object return $input; } -if (is_ajax()) { - my $input = &ajax_auth_cgi($needed_flags); - my $operator = C4::Context->userenv->{'number'}; # must occur AFTER auth - my $js_reply; - my $op = $input->param('op') || q{}; - my $tag = $input->param('tag'); +if ( is_ajax() ) { + my $input = &ajax_auth_cgi($needed_flags); + my $operator = C4::Context->userenv->{'number'}; # must occur AFTER auth + my $op = $input->param('op') || q{}; + my $tag = $input->param('tag'); my $status; if ( $op eq 'test' ) { my $check = is_approved($tag);