Bug 36897: Make it possible to use select[multiple] and select[size] in a sidebar

Currently, if you put either <select multiple> or <select size="10"> in
an <aside><fieldset> sidebar, you get a height of "one fat line" rather
than the bigger box you would expect.

Test plan:
 1. Without the patch, load Reports - Use saved
 2. Open Firefox developer tools to the Inspector tab
 3. With the "Pick an element from the page" tool, click on the word
    "Filter" in the Reports page's sidebar
 4. Just above that line in the HTML display is a <fieldset
    class="brief"> - right click that and choose Edit As HTML
 5. After the fieldset element, paste

<select multiple><option>one</option><option>two</option></select><select size="10"></select>

 6. Click outside the editor to save your changes
 7. Note that both new selects are only one line high
 8. Apply patch, run yarn build, Shift+reload to clear your cache
 9. Repeat steps 3 through 6
10. Note that both selects are more than one line high
11. Set the preference EnableAdvancedCatalogingEditor to Enable
12. Cataloging - Advanced editor
13. In the left sidebar, verify that the Clipboard is still 10 lines high,
    not one fat line like it was before bug 36589

Sponsored-by: Chetco Community Public Library
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Phil Ringnalda 2025-03-16 21:53:32 -07:00 committed by Pedro Amorim
parent 84948a6041
commit 67da9d31ec
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
2 changed files with 1 additions and 5 deletions

View File

@ -69,10 +69,6 @@ body {
font-size: 12px;
}
#clipboard {
height: auto;
}
/*> MARC editor */
#editor .CodeMirror {
line-height: 1.2;

View File

@ -366,7 +366,7 @@ aside {
}
input[type="text"],
select {
select:not([multiple], [size]) {
height: calc( 1.5em + .75rem + 2px );
}