Bug 30199: Do not generate jwt if patron does not exist
This is a follow-up patch for bug 29543. If an invalid cardnumber has been used we should not generate a token. Test Plan: 1. Set SelfCheckoutByLogin to 'cardnumber'. 2. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3. Enter an invalid carnumber like 'thisisabadcardnumber' 4. See the appropriate message "Sorry The userid thisisabadcardnumber was not found in the database. Please try again." 5. Try again with a different cardnumber and notice the same exact error message including the 'thisisabadcardnumber' cardnumber. 6. Apply this patch 7. Restart all the things! 8. Repeat steps 2-4 9. Try again with a different cardnumber, you should now see the correct cardnumber! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (cherry picked from commite5aeb047a5) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> (cherry picked from commita7bc65b0a3) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
This commit is contained in:
parent
d890b84e3e
commit
661147c6db
|
|
@ -134,6 +134,8 @@ if ( $patronid ) {
|
|||
$patron = Koha::Patrons->find( { cardnumber => $patronid } );
|
||||
}
|
||||
|
||||
undef $jwt unless $patron;
|
||||
|
||||
my $branch = $issuer->{branchcode};
|
||||
my $confirm_required = 0;
|
||||
my $return_only = 0;
|
||||
|
|
|
|||
Loading…
Reference in New Issue