gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 9206 - Only allow place holds in records that the patron don't have in his possession 

Added a system preference to turn on/off this feature.
By default the system allow the patron to place holds even if it is in his possession.
Script to place holds check if the system preference is off and if patron has at least one item to block holds.
Messages to say that are already in patron possession added to templates.
Method to check if patron has one issue from one record added to C4::Circulation

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Vitor FERNANDES 2012-12-04 15:57:35 +00:00 committed by Jared Camins-Esakov
parent 8ce80b9ad4
commit 63f2ceb603
8 changed files with 57 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
C4/Circulation.pm
View File

@ -3445,6 +3445,27 @@ sub TransferSlip {
);
}
=head2 CheckIfIssuedToPatron
CheckIfIssuedToPatron($borrowernumber, $biblionumber)
Return 1 if any record item is issued to patron, otherwise return 0
=cut
sub CheckIfIssuedToPatron {
my ($borrowernumber, $biblionumber) = @_;
my $isissued = 0;
my $items = GetItemsByBiblioitemnumber($biblionumber);
foreach my $item (@{$items}) {
$isissued = 1 if ($item->{borrowernumber} && $item->{borrowernumber} eq $borrowernumber);
}
return $isissued;
}
1;

1
installer/data/mysql/sysprefs.sql
View File

@ -402,3 +402,4 @@ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('
INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('RenewalSendNotice','0', NULL, '', 'YesNo');
INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('HTML5MediaEnabled','not','Show a tab with a HTML5 media player for files catalogued in field 856','not|opac|staff|both','Choice');
INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('HTML5MediaExtensions','webm|ogg|ogv|oga|vtt','Media file extensions','','free');
INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AllowHoldsOnPatronsPossessions', '1', 'Allow holds on records that patron have items of it',NULL,'YesNo');

8
installer/data/mysql/updatedatabase.pl
View File

@ -6111,6 +6111,14 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
print "Upgrade to $DBversion done (Bug 8782: Add field subscription.closed)\n";
SetVersion($DBversion);
}
$DBversion = "XXX";
if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
$dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AllowHoldsOnPatronsPossessions', '1', 'Allow holds on records that patron have items of it',NULL,'YesNo')"
print "Upgrade to $DBversion done (Bug 9206: Only allow place holds in records that the patron don't have in his possession)\n";
SetVersion($DBversion);
}
$DBversion = "3.11.00.005";
if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {

6
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
View File

@ -441,6 +441,12 @@ Circulation:
- pref: decreaseLoanHighHoldsValue
class: integer
- holds.
-
- pref: AllowHoldsOnPatronsPossessions
choices:
yes: Allow
no: "Don't allow"
- patrons to place holds on records that he already have any item of it in his possession.
Fines Policy:
-
- Calculate fines based on days overdue

3
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -212,6 +212,9 @@ function checkMultiHold() {
[% END %]
[% IF ( none_available ) %]
<li> <strong>No copies are available</strong> to be placed on hold</li>
[% END %]
[% IF ( alreadypossession ) %]
<li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>is already in possesion</strong> of one item</li>
[% END %]
</ul>
[% ELSE %]

8
koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
View File

@ -293,8 +293,12 @@
[% UNLESS ( bibitemloo.bib_available ) %]
<div class="bibmessage">No available items.</div>
[% ELSE %]
<div class="bibmessage">This title cannot be requested.</div>
[% END %]
[% IF ( bibitemloo.already_patron_possession ) %]
<div class="bibmessage">This title cannot be requested because it's already in your possession.</div>
[% ELSE %]
<div class="bibmessage">This title cannot be requested.</div>
[% END %]
[% END %]
[% END %]

5
opac/opac-reserve.pl
View File

@ -537,6 +537,11 @@ foreach my $biblioNum (@biblionumbers) {
$biblioLoopIter{holdable} = undef;
$anyholdable = undef;
}
if(not C4::Context->preference('AllowHoldsOnPatronsPossessions') and CheckIfIssuedToPatron($borrowernumber,$biblioNum)) {
$biblioLoopIter{holdable} = undef;
$biblioLoopIter{already_patron_possession} = 1;
$anyholdable = undef;
}
push @$biblioLoop, \%biblioLoopIter;
}

8
reserve/request.pl
View File

@ -247,6 +247,11 @@ foreach my $biblionumber (@biblionumbers) {
$warnings = 1;
$maxreserves = 1;
}
if (not C4::Context->preference('AllowHoldsOnPatronsPossessions') and CheckIfIssuedToPatron($borrowerinfo->{borrowernumber},$biblionumber)) {
$warnings = 1;
$alreadypossession = 1;
}
# get existing reserves .....
my ( $count, $reserves ) = GetReservesFromBiblionumber($biblionumber,1);
my $totalcount = $count;
@ -268,7 +273,8 @@ foreach my $biblionumber (@biblionumbers) {
$template->param( alreadyreserved => $alreadyreserved,
messages => $messages,
warnings => $warnings,
maxreserves=>$maxreserves
maxreserves=>$maxreserves,
alreadypossession => $alreadypossession,
);