gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24031: (QA follow-up) Add tests for the AddReserve intervention 

This patch adds tests for AddReserve

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomas Cohen Arazi 2020-07-24 15:42:17 -03:00 committed by Jonathan Druart
parent 0f54ace671
commit 625ba7a2aa
2 changed files with 84 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
t/db_dependent/Koha/Plugins/Holds_hooks.t Executable file
View File

@ -0,0 +1,82 @@
#!/usr/bin/perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 3 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 4;
use Test::MockModule;
use Test::Warn;
use File::Basename;
use C4::Reserves qw(AddReserve);
use t::lib::Mocks;
use t::lib::TestBuilder;
BEGIN {
# Mock pluginsdir before loading Plugins module
my $path = dirname(__FILE__) . '/../../../lib';
t::lib::Mocks::mock_config( 'pluginsdir', $path );
use_ok('Koha::Plugins');
use_ok('Koha::Plugins::Handler');
use_ok('Koha::Plugin::Test');
}
my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;
t::lib::Mocks::mock_config( 'enable_plugins', 1 );
subtest 'after_hold_create() hook tests' => sub {
plan tests => 1;
$schema->storage->txn_begin;
my $plugins = Koha::Plugins->new;
$plugins->InstallPlugins;
my $plugin = Koha::Plugin::Test->new->enable;
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
t::lib::Mocks::mock_userenv(
{
patron => $patron,
branchcode => $patron->branchcode
}
);
# Avoid testing useless warnings
my $test_plugin = Test::MockModule->new('Koha::Plugin::Test');
$test_plugin->mock( 'after_item_action', undef );
$test_plugin->mock( 'after_biblio_action', undef );
my $biblio = $builder->build_sample_biblio();
my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
warning_like { AddReserve({
branchcode => $patron->branchcode,
borrowernumber => $patron->borrowernumber,
biblionumber => $item_1->biblionumber }); }
qr/after_hold_create called with parameter Koha::Hold/,
'AddReserve calls the after_hold_create hook';
$schema->storage->txn_rollback;
Koha::Plugins::Methods->delete;
};

3
t/lib/Koha/Plugin/Test.pm
View File

@ -128,7 +128,8 @@ sub api_namespace {
}
sub after_hold_create {
return "Koha::Plugin::Test::after_hold_create";
my ( $self, $param ) = @_;
Koha::Exceptions::Exception->throw("after_hold_create called with parameter " . ref($param) );
}
sub after_biblio_action {