gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24614: Fix Reports/Guided.t 

DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement "UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?, `report_group` = ?, `report_name` = ?, `report_subgroup` = ?,
`savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04', 1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
    # Looks like you planned 17 tests but ran 6.

update_sql expect all the paramters to be set, otherwise it will be
nulled.

The best way to fix it is at test level. There is only 1 occurrence in
controller/module, and it sends all the parameters. That is the correct
way to do and will make things easier when we will removed them to use
Koha::Reports directly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2020-03-27 17:09:27 +01:00 committed by Joy Nelson
parent 0a6c345703
commit 60c88bfa2f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/db_dependent/Reports/Guided.t
View File

@ -217,7 +217,7 @@ subtest 'get_saved_reports' => sub {
ok( 0 < scalar @{ get_saved_reports( $report_ids[0] ) }, "filter takes report id" );
my $r1 = Koha::Reports->find($report_ids[0]);
$r1 = update_sql($r1->id, { borrowernumber => $r1->borrowernumber, name => 'Just another report' });
$r1 = update_sql($r1->id, { %{$r1->unblessed}, borrowernumber => $r1->borrowernumber, name => 'Just another report' });
is( $r1->cache_expiry, 300, 'cache_expiry has the correct default value, from DBMS' );
#Test delete_report