gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug 8215: (followup) avoid SQL syntax error in logs 

ModItem currently will attempt to update an item
even if no field updates are specified.  This patch
avoids (harmless) error messages in the Apache
logs if an item is not actually being changed when it
is placed or taken off reserve.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Galen Charlton 2013-05-21 10:12:15 -07:00
parent f5fac05624
commit 5ed6a9f35c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
C4/CourseReserves.pm
View File

@ -568,7 +568,7 @@ sub _UpdateCourseItem {
$mod_params{$_} = $params{$_};
}
}
ModItem( \%mod_params, undef, $course_item->{'itemnumber'} );
ModItem( \%mod_params, undef, $course_item->{'itemnumber'} ) if %mod_params;
## Update fields that didn't have an original value, but now do
## We must save the original value in course_items, and also
@ -583,7 +583,7 @@ sub _UpdateCourseItem {
}
}
_ModStoredFields( 'ci_id' => $params{'ci_id'}, %mod_params_old );
ModItem( \%mod_params_new, undef, $course_item->{'itemnumber'} );
ModItem( \%mod_params_new, undef, $course_item->{'itemnumber'} ) if %mod_params_new;
}
@ -648,7 +648,7 @@ sub _RevertFields {
}
}
}
ModItem( $mod_item_params, undef, $course_item->{'itemnumber'} );
ModItem( $mod_item_params, undef, $course_item->{'itemnumber'} ) if $mod_item_params && %$mod_item_params;
my $query = "UPDATE course_items SET " . join( ',', map { "$_=NULL" } @fields_to_null ) . " WHERE ci_id = ?";
@ -677,7 +677,7 @@ sub _SwapAllFields {
}
}
ModItem( \%course_item_fields, undef, $course_item->{'itemnumber'} );
ModItem( \%course_item_fields, undef, $course_item->{'itemnumber'} ) if %course_item_fields;
_ModStoredFields( %item_fields, ci_id => $ci_id );
}