gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37892: (QA follow-up) Fix condition in memberentry 

Patron may be undefined. So the test may crash.
Also there is an issue with operator precedence.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit cfc953a411)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2024-09-20 09:07:42 +00:00 committed by Lucas Gass
parent 74e4173dd8
commit 5e07ef7ae7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
members/memberentry.pl
View File

@ -280,7 +280,9 @@ if ( ( $op eq 'cud-save' || $op eq 'cud-insert' )
}
foreach my $guarantor (@guarantors) {
if ( ( $op eq 'cud-save' || $op eq 'cud-insert' ) && ($guarantor->is_child ) || $guarantor->is_guarantee || $patron->is_guarantor) {
if ( ( $op eq 'cud-save' || $op eq 'cud-insert' )
&& ( $guarantor->is_child || $guarantor->is_guarantee || ( $patron && $patron->is_guarantor ) ) )
{
push @errors, 'ERROR_guarantor_is_guarantee';
}
}