From 5d5ccb8073fab05ec47b231f3de33e2e6121721d Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 16 Jul 2025 11:59:17 +0200
Subject: [PATCH] Bug 40405: Set decreaseLoanHighHolds\* to 0

When reviewing the different sysprefs that had "NULL" as default, I
only found those 2 occurrences that could be problematic. I think we
should default to 0 here.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit ca6cbc3cf92ff2cf990a99261367d7ab6eec3879)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
---
 C4/Circulation.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index 0be2b4f2ea..c53e799dde 100644
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -1457,7 +1457,7 @@ sub checkHighHolds {
         $return_data->{outstanding} = $holds->count();
 
         my $decreaseLoanHighHoldsControl        = C4::Context->preference('decreaseLoanHighHoldsControl');
-        my $decreaseLoanHighHoldsValue          = C4::Context->preference('decreaseLoanHighHoldsValue');
+        my $decreaseLoanHighHoldsValue          = C4::Context->preference('decreaseLoanHighHoldsValue') || 0;
         my $decreaseLoanHighHoldsIgnoreStatuses = C4::Context->preference('decreaseLoanHighHoldsIgnoreStatuses');
 
         my @decreaseLoanHighHoldsIgnoreStatuses = split( /,/, $decreaseLoanHighHoldsIgnoreStatuses );
@@ -1529,7 +1529,7 @@ sub checkHighHolds {
             # overrides decreaseLoanHighHoldsDuration syspref
             $duration = $rule;
         } else {
-            $duration = C4::Context->preference('decreaseLoanHighHoldsDuration');
+            $duration = C4::Context->preference('decreaseLoanHighHoldsDuration') || 0;
         }
         my $reduced_datedue = $calendar->addDuration( $issuedate, $duration );
         $reduced_datedue->set_hour( $orig_due->hour );