gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 36081: Fix some failing tests 

Signed-off-by: Magnus Enger <magnus@libriotech.no>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
This commit is contained in:
Jonathan Druart 2025-02-10 11:31:34 +01:00 committed by Alex Buckley
parent 05353f0cf0
commit 5a8aef083d
4 changed files with 53 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
t/db_dependent/ArticleRequests.t
View File

@ -69,12 +69,15 @@ my $patron_2 = $builder->build_object({ class => 'Koha::Patrons', value => { fla
# store
Koha::Notice::Messages->delete;
my $article_request_title = 'an article request title';
my $article_request = Koha::ArticleRequest->new(
my $article_request = $builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->itemnumber,
title => $article_request_title,
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->itemnumber,
title => $article_request_title,
}
}
)->request();

41
t/db_dependent/Koha/ArticleRequest.t
View File

@ -46,10 +46,14 @@ subtest 'request() tests' => sub {
my $ar_module = mock_article_request_module();
my $ar = Koha::ArticleRequest->new(
my $ar = $builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
debit_id => undef,
}
}
);
@ -67,11 +71,14 @@ subtest 'request() tests' => sub {
# set a fee amount
$amount = 10;
$ar = Koha::ArticleRequest->new(
$ar = $builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->id,
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->id,
}
}
);
@ -101,10 +108,13 @@ subtest 'set_pending() tests' => sub {
my $ar_module = mock_article_request_module();
my $ar = Koha::ArticleRequest->new(
my $ar = $builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $biblio->id,
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $biblio->id,
}
}
);
@ -174,11 +184,14 @@ subtest 'cancel() tests' => sub {
my $ar_module = mock_article_request_module();
my $ar = Koha::ArticleRequest->new(
my $ar = $builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->id,
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->id,
}
}
);

14
t/db_dependent/Koha/Biblio.t
View File

@ -1331,12 +1331,16 @@ subtest 'article_requests() tests' => sub {
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
Koha::ArticleRequest->new(
$builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $biblio->id,
itemnumber => $item->id,
title => $biblio->title,
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $biblio->id,
itemnumber => $item->id,
title => $biblio->title,
}
}
)->request;
}

14
t/db_dependent/Koha/Patron.t
View File

@ -1348,12 +1348,16 @@ subtest 'article_requests() tests' => sub {
my $item = $builder->build_sample_item;
Koha::ArticleRequest->new(
$builder->build_object(
{
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->id,
title => "Title",
class => 'Koha::ArticleRequests',
value => {
borrowernumber => $patron->id,
biblionumber => $item->biblionumber,
itemnumber => $item->id,
title => "Title",
}
}
)->request;
}