gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37893: Handle SIPconfig.xml not found / unreadable 

prove t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Pedro Amorim 2025-11-24 11:39:45 +00:00 committed by Lucas Gass
parent 0eb18dffd7
commit 592d966d67
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
2 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
installer/data/mysql/db_revs/250600035.pl
View File

@ -243,6 +243,12 @@ return {
}
my $SIPconfigFile = "/etc/koha/sites/$koha_instance/SIPconfig.xml";
unless ( -f $SIPconfigFile && -r $SIPconfigFile ) {
say_warning( $out, "Skipping migration. SIP config file not found or unreadable" );
return;
}
say_info( $out, "Reading SIPconfig.xml for $koha_instance located at $SIPconfigFile" );
my $SIPconfig = C4::SIP::Sip::Configuration->new($SIPconfigFile);

32
t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t
View File

@ -17,8 +17,9 @@
use Modern::Perl;
use Test::More tests => 3;
use Test::More tests => 4;
use Test::NoWarnings;
use Test::MockModule;
use t::lib::TestBuilder;
@ -175,3 +176,32 @@ subtest 'config_timestamp is updated when database configuration changes' => sub
$schema->storage->txn_rollback;
};
subtest 'Atomicupdate skips migrating data if provided config file doesn\'t exist or is unreadable' => sub {
plan tests => 1;
my $captured_message;
my $mock = Test::MockModule->new('Koha::Installer::Output');
$mock->mock(
'say_warning',
sub {
my ( $out_object, $message ) = @_;
$captured_message = $message;
}
);
my $koha_instance = $ENV{KOHA_CONF} =~ m!^.+/sites/([^/]+)/koha-conf\.xml$! ? $1 : undef;
my $SIPconfigXMLFile = "/etc/koha/sites/$koha_instance/SIPconfig.xml";
my $fileSIPconfig = C4::SIP::Sip::Configuration->new($SIPconfigXMLFile);
rename $SIPconfigXMLFile, "/etc/koha/sites/$koha_instance/IDontExist.xml";
my $db_rev_file = C4::Context->config('intranetdir') . '/installer/data/mysql/db_revs/250600035.pl';
C4::Installer::run_db_rev($db_rev_file);
is(
$captured_message,
"Skipping migration. SIP config file not found or unreadable",
'say_warning received the correct migration skip message'
);
rename "/etc/koha/sites/$koha_instance/IDontExist.xml", $SIPconfigXMLFile;
}