gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BUGFIX - get_batches argument counterproductive. NONE of the Labels code 

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This commit is contained in:
Joe Atzberger 2008-04-28 15:31:27 -05:00 committed by Joshua Ferraro
parent 3a1542c423
commit 58e5e0a236
1 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
C4/Labels.pm
View File

@ -353,24 +353,14 @@ sub get_highest_batch {
sub get_batches {
my ( $batch_type ) = @_;
my $dbh = C4::Context->dbh;
my $q = "SELECT batch_id, COUNT(*) AS num FROM $batch_type GROUP BY batch_id";
my $sth = $dbh->prepare($q);
# my $q = "SELECT batch_id, COUNT(*) AS num FROM " . shift . " GROUP BY batch_id";
# FIXEDME: There is only ONE table with batch_id, so why try to select a different one?
# get_batches() was frequently being called w/ no args, crashing DBD
my $q = "SELECT batch_id, COUNT(*) AS num FROM labels GROUP BY batch_id";
my $sth = C4::Context->dbh->prepare($q);
$sth->execute();
my @resultsloop;
while ( my $data = $sth->fetchrow_hashref ) {
push( @resultsloop, $data );
}
$sth->finish;
# Not sure why we are doing this rather than simply telling the user that no batches are currently defined.
# So I'm commenting this out and modifying label-manager.tmpl to properly inform the user as stated. -fbcit
# adding a dummy batch=1 value , if none exists in the db
# if ( !scalar(@resultsloop) ) {
# push( @resultsloop, { batch_id => '1' , num => '0' } );
# }
return @resultsloop;
my $batches = $sth->fetchall_arrayref({});
return @$batches;
}
sub delete_batch {