gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix for 1521, boolean test for 'autobarcode' syspref fixed, and test for non-existant $marc->field before barcode subfield add 

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This commit is contained in:
Mason James 2007-10-31 03:44:46 -05:00 committed by Joshua Ferraro
parent b21773d71d
commit 58dfd9c18e
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
serials/serials-edit.pl
View File

@ -221,20 +221,21 @@ if ($op eq 'serialchangestatus') {
my $record=MARC::Record::new_from_xml($xml, 'UTF-8');
if ($item=~/^N/){
#New Item
# if autoBarcode is ON, calculate barcode...
my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode");
if (C4::Boolean::true_p(C4::Context->preference("autoBarcode")) != 0 ) {
if (C4::Context->preference("autoBarcode") ne 'OFF' ) {
unless ($record->field($tagfield)->subfield($tagsubfield)) {
eval { $record->field($tagfield)->subfield($tagsubfield) };
if ($@) {
my $sth_barcode = $dbh->prepare("select max(abs(barcode)) from items");
$sth_barcode->execute;
my ($newbarcode) = $sth_barcode->fetchrow;
$newbarcode++;
# OK, we have the new barcode, now create the entry in MARC record
my $fieldItem = $record->field($tagfield);
$record->delete_field($fieldItem);
$fieldItem->add_subfields($tagsubfield => $newbarcode);
$record->insert_fields_ordered($fieldItem);
$record->add_fields( $tagfield, "1", "0",
$tagsubfield => $newbarcode );
}
}
# check for item barcode # being unique